fix: UserErrors leave json_parse in an invalid state #12308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When json_parse throws a user error and it's not wrapped in a try, if that exception is caught outside expression evaluation and the ExprSet attempts to be reused, the json_parse function may be in an invalid state and will throw a runtime exception. This was exposed in ExpressionFuzzer after facebookincubator#12281 was landed. This fix is to clear the state whenever we see a UserException after calling parse whether or not the function is wrapped in a try. Differential Revision: D69473523
|
This pull request was exported from Phabricator. Differential Revision: D69473523 |
✅ Deploy Preview for meta-velox canceled.
|
kgpai
approved these changes
Feb 11, 2025
|
This pull request has been merged in b71648f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When json_parse throws a user error and it's not wrapped in a try, if that exception is caught
outside expression evaluation and the ExprSet attempts to be reused, the json_parse function
may be in an invalid state and will throw a runtime exception.
This was exposed in ExpressionFuzzer after
#12281 was landed.
This fix is to clear the state whenever we see a UserException after calling parse whether or not
the function is wrapped in a try.
Differential Revision: D69473523