fix: Wildcard support in json extract using simdjson #12281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D69281233 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
approved these changes
Feb 7, 2025
|
Could you fix the title before landing, I think the w in "wildcard" needs to be upper case |
…or#12281) Summary: This change addresses 2 bugs in the wildcard support of json_extract: Bug 1: Failure to iterate on values inside an object, resulting in empty arrays. For eg: calling JSON_EXTRACT( JSON '{"foo": {"a" : {"c": 1 , "d": 3} }, "b": 2}', '$.foo.a.[*]') will return an empty array whereas we expect [1, 3] Bug 2: Inconsistent handling of indefinite results, always returning a JSON array even when the token is not evaluated. or eg: JSON_EXTRACT('({"a": {"b": [123, 456]}})', '$.a.c[*]') should return NULL instead of [] as the key 'c' does not exist. Reviewed By: kevinwilfong Differential Revision: D69281233
2d6496e to
2db2e90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69281233 |
|
This pull request has been merged in e383017. |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Feb 11, 2025
Summary: When json_parse throws a user error and it's not wrapped in a try, if that exception is caught outside expression evaluation and the ExprSet attempts to be reused, the json_parse function may be in an invalid state and will throw a runtime exception. This was exposed in ExpressionFuzzer after facebookincubator#12281 was landed. This fix is to clear the state whenever we see a UserException after calling parse whether or not the function is wrapped in a try. Differential Revision: D69473523
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
Summary: Pull Request resolved: #12308 When json_parse throws a user error and it's not wrapped in a try, if that exception is caught outside expression evaluation and the ExprSet attempts to be reused, the json_parse function may be in an invalid state and will throw a runtime exception. This was exposed in ExpressionFuzzer after #12281 was landed. This fix is to clear the state whenever we see a UserException after calling parse whether or not the function is wrapped in a try. Reviewed By: kgpai Differential Revision: D69473523 fbshipit-source-id: d4ae34d65136ce80138f9ed2e7f6f86bf566011e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change addresses 2 bugs in the wildcard support of json_extract:
Bug 1: Failure to iterate on values inside an object, resulting in
empty arrays.
For eg: calling JSON_EXTRACT(
JSON '{"foo": {"a" : {"c": 1 , "d": 3} }, "b": 2}', '$.foo.a.[*]')
will return an empty array whereas we expect [1, 3]
Bug 2: Inconsistent handling of indefinite results, always returning a
JSON array even when the token is not evaluated.
or eg: JSON_EXTRACT('({"a": {"b": [123, 456]}})', '$.a.c[*]') should
return NULL instead of [] as the key 'c' does not exist.
Differential Revision: D69281233