You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This diff is probably fine, the reason for the back out is because ipprefix triggered unaligned memory access more frequently (#11574) . We can now re-land this diff as is.
yuandagits
changed the title
Back out "Back out "[velox] misc(revert ipaddress cast): Add ipprefix cast operators for varchar [1/n]""
misc: Back out "Back out "[velox] misc(revert ipaddress cast): Add ipprefix cast operators for varchar [1/n]""
Nov 19, 2024
misc: Back out "Back out "[velox] misc(revert ipaddress cast): Add ipprefix cast operators for varchar [1/n]""
Hm, to me it's very unclear what's actually happening. Should this just be 'feat(ipprefix): Add cast operators for varchar [1/n]'?
@pedroerp with 'Backout' type of commits being a thing should we add a note on how to handle these with regards to conventional commits? Thinking about semver and changelogs we want to be able to detect backouts and also remove the backed out commit from considerations. Maybe something like revert(short-sha): ... or misc(revert): Backout <sha> due to ...?
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.fb-exportedMerged
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff is probably fine, the reason for the back out is because ipprefix triggered unaligned memory access more frequently (#11574) . We can now re-land this diff as is.