fix: Unaligned memory access in ByteStream and PrestoSerializer #11574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D66125705 |
yuandagits
approved these changes
Nov 19, 2024
…bookincubator#11574) Summary: We have a few places in the serialization code that do unaligned memory access. This is causing crashes in `ByteOutputStream::append<int128>` and we clean them up in this change. Reviewed By: yuandagits Differential Revision: D66125705
dcdd9d5 to
c44d65d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66125705 |
|
This pull request has been merged in af6609d. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…bookincubator#11574) Summary: Pull Request resolved: facebookincubator#11574 We have a few places in the serialization code that do unaligned memory access. This is causing crashes in `ByteOutputStream::append<int128>` and we clean them up in this change. Reviewed By: yuandagits Differential Revision: D66125705 fbshipit-source-id: 32d59d7cafc3b0870313fc04bfc46e0d5e9cc30a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have a few places in the serialization code that do unaligned memory
access. This is causing crashes in
ByteOutputStream::append<int128>and weclean them up in this change.
Differential Revision: D66125705