Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli-tests issues #3509

Merged

Conversation

daniellerozenblit
Copy link
Contributor

Fix for issues #3501 and #3502.

All tests now seem to pass for make -C tests test-cli-tests CFLAGS="-O2 -m32" and make -C tests test-cli-tests HAVE_ZLIB=0.

@daniellerozenblit daniellerozenblit marked this pull request as ready for review February 14, 2023 19:42
@Cyan4973
Copy link
Contributor

Thanks @daniellerozenblit ! Great fix !

Another point : it seems we have been missing this issue, because we were lacking the relevant test to detect it.

Could you add it to this PR too ?
Thanks!

@daniellerozenblit daniellerozenblit merged commit 345ed63 into facebook:dev Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants