Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new "cli-tests" from 1.5.4 fail if zstd is built with HAVE_ZLIB=0. #3501

Closed
ilyakurdyukov opened this issue Feb 13, 2023 · 1 comment
Closed
Assignees

Comments

@ilyakurdyukov
Copy link
Contributor

Describe the bug

Please make proper tests that won't fail if something is built with non-default options:

FAIL: compression/basic.sh
FAIL: compression/gzip-compat.sh
FAILED 2 / 37 tests!

"basic.sh" stderr:

# Test keeping input file when compressing to stdout in gzip mode
$ZSTD_SYMLINK_DIR/gzip -c file       | zstd -t ; test -f file
zstd: error 20 : zstd: file: file cannot be compressed as gzip (zstd compiled without ZSTD_GZCOMPRESS) -- ignored 

"gzip-compat.sh" stderr:

# Test gzip specific compression option
$ZSTD_SYMLINK_DIR/gzip --fast file ; $ZSTD_SYMLINK_DIR/gzip -d file.gz
zstd: error 20 : zstd: file: file cannot be compressed as gzip (zstd compiled without ZSTD_GZCOMPRESS) -- ignored 

To Reproduce

make HAVE_ZLIB=0
make -C tests test-cli-tests HAVE_ZLIB=0
@Cyan4973
Copy link
Contributor

Indeed, these tests should first ensure that the tested binary features gzip support before proceeding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants