Initial implementation of issue #2112 #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase but let's get it in sooner rather than later to avoid merge conflicts. |
4b93993 to
a6c175d
Compare
a6c175d to
081feeb
Compare
jimfb
added a commit
that referenced
this pull request
Nov 18, 2014
Initial implementation of issue #2112
| * @return {string} the HTML markup | ||
| */ | ||
| function renderToString(element) { | ||
| function renderToString(element, context) { | ||
| if(context === undefined) context = emptyObject; |
There was a problem hiding this comment.
:( @sebmarkbage I'm going to work on the style automation & linting as much as possible, but let's try to catch things like this (space before open paren, newlines with braces for ifs). Especially important for new contributors.
There was a problem hiding this comment.
@zpao No time. We needed to avoid another merge-hell.
However, I missed that renderToString still accepts a context. It shouldn't.
There was a problem hiding this comment.
renderToString fixed in #2565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at the implementation of issue #2112, posted primarily to get early feedback. The change is not ready to be merged, though it shouldn't break anything.
TODO: