Fix lint warnings, style fixups #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ var ReactDOMTextComponent = function(props) { | |||
| assign(ReactDOMTextComponent.prototype, { | |||
|
|
|||
| /** | |||
| * @param {ReactText} node | |||
| * @param {ReactText} text | |||
There was a problem hiding this comment.
Our runtime typecheck transform fails here because it text and node don't match (more specifically, I think it will fail if you specify things in the docblock that aren't in the parameters, but not visa versa)
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); |
|
boom thanks :) |
079fe29 to
af1d6fd
Compare
| @@ -101,7 +101,7 @@ function instantiateReactComponent(node, parentCompositeType) { | |||
| } else { | |||
| invariant( | |||
| false, | |||
| 'Encountered invalid React node of type ' + typeof node | |||
| 'Encountered invalid React node of type undefined, symbol, or boolean.' | |||
There was a problem hiding this comment.
We have a lint rule internally about invariant's second arg being a string literal. I'm not entirely sure why but I figured it's important enough to listen to.
Followup work for recent PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup work for recent PRs