Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when doing createRoot twice on the same node (another approach) #17329

Merged
merged 5 commits into from
Nov 10, 2019
Merged

Warn when doing createRoot twice on the same node (another approach) #17329

merged 5 commits into from
Nov 10, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 10, 2019

Alternative to #17328. Uses an existing flag. First commit is a refactoring, second adds a new warning.

@gaearon gaearon mentioned this pull request Nov 10, 2019
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 10, 2019 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b84f028:

Sandbox Source
dazzling-cartwright-tztqd Configuration

@sizebot
Copy link

sizebot commented Nov 10, 2019 •
edited
Loading

Details of bundled changes.

Comparing: be3bfa6...b84f028

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% +0.1% 123.54 KB 123.6 KB 38.79 KB 38.81 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140.2 KB 140.2 KB 36.81 KB 36.81 KB UMD_DEV
react-dom-unstable-flight-server.browser.development.js 0.0% 0.0% 9.34 KB 9.34 KB 3.06 KB 3.06 KB UMD_DEV
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.1% 2.85 KB 2.85 KB 1.33 KB 1.33 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 56.1 KB 56.1 KB 15.52 KB 15.52 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-unstable-flight-client.development.js 0.0% 0.0% 8.72 KB 8.72 KB 2.59 KB 2.6 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 708 B 710 B UMD_PROD
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.89 KB 2.89 KB 1.34 KB 1.34 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 139.57 KB 139.57 KB 35.4 KB 35.4 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 54.37 KB 54.37 KB 15.18 KB 15.18 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.54 KB 8.54 KB 2.55 KB 2.55 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.05 KB 1.05 KB 639 B 641 B NODE_PROD
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.72 KB 2.72 KB 1.28 KB 1.28 KB NODE_PROD
react-dom.development.js +0.1% +0.1% 951.92 KB 952.75 KB 215.26 KB 215.4 KB UMD_DEV
react-dom.production.min.js 0.0% 🔺+0.2% 119.57 KB 119.63 KB 38.35 KB 38.42 KB UMD_PROD
react-dom.profiling.min.js 0.0% +0.1% 123.25 KB 123.31 KB 39.44 KB 39.47 KB UMD_PROFILING
react-dom.development.js +0.1% +0.1% 946.03 KB 946.86 KB 213.68 KB 213.82 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.24 KB 137.24 KB 36.03 KB 36.03 KB NODE_DEV
react-dom-unstable-flight-server.node.development.js 0.0% 0.0% 10.03 KB 10.03 KB 3.27 KB 3.27 KB NODE_DEV
react-dom.production.min.js 0.0% 🔺+0.1% 119.74 KB 119.8 KB 37.73 KB 37.76 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.72 KB 20.72 KB 7.61 KB 7.61 KB NODE_PROD
react-dom-unstable-flight-server.node.production.min.js 0.0% 🔺+0.2% 2.81 KB 2.81 KB 1.28 KB 1.29 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 136.13 KB 136.13 KB 35.81 KB 35.81 KB NODE_DEV
react-dom-unstable-flight-server.browser.development.js 0.0% 0.0% 9.13 KB 9.13 KB 3.01 KB 3.01 KB NODE_DEV
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.2% 2.65 KB 2.65 KB 1.26 KB 1.26 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.14 KB 60.14 KB 15.79 KB 15.8 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.73 KB 10.73 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOM-dev.js +0.1% +0.1% 974.39 KB 975.23 KB 216.25 KB 216.39 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 🔺+0.1% 402.36 KB 402.56 KB 73.11 KB 73.16 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.82 KB 59.82 KB 15.66 KB 15.66 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOM-profiling.js 0.0% +0.1% 403.2 KB 403.39 KB 73.67 KB 73.72 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.48 KB 10.48 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 695 B 697 B NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against b84f028

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2019

Huh. The failure is funny. I forgot about the case of two renderers.

@sizebot
Copy link

sizebot commented Nov 10, 2019 •
edited
Loading

Details of bundled changes.

Comparing: be3bfa6...b84f028

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.46 KB 10.46 KB 3.56 KB 3.57 KB NODE_PROD
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.2% 2.64 KB 2.64 KB 1.25 KB 1.25 KB NODE_PROD
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.7 KB 8.7 KB 2.59 KB 2.59 KB UMD_DEV
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.88 KB 2.88 KB 1.33 KB 1.34 KB UMD_PROD
react-dom-unstable-flight-server.node.development.js 0.0% 0.0% 10.02 KB 10.02 KB 3.26 KB 3.26 KB NODE_DEV
react-dom.development.js +0.1% +0.1% 951.9 KB 952.73 KB 215.24 KB 215.38 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.85 KB 19.85 KB 7.38 KB 7.38 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom-unstable-flight-server.node.production.min.js 0.0% 🔺+0.1% 2.8 KB 2.8 KB 1.27 KB 1.28 KB NODE_PROD
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 116.16 KB 116.22 KB 37.43 KB 37.45 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 700 B 702 B UMD_PROD
react-dom.profiling.min.js 0.0% +0.1% 119.73 KB 119.79 KB 38.49 KB 38.51 KB UMD_PROFILING
react-dom.development.js +0.1% +0.1% 946.01 KB 946.83 KB 213.66 KB 213.8 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.49 KB 1.49 KB NODE_DEV
react-dom.production.min.js 🔺+0.1% 🔺+0.1% 116.3 KB 116.36 KB 36.79 KB 36.82 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.5% 1.04 KB 1.04 KB 631 B 634 B NODE_PROD
react-dom-unstable-flight-server.browser.development.js 0.0% 0.0% 9.32 KB 9.32 KB 3.06 KB 3.06 KB UMD_DEV
react-dom.profiling.min.js 0.0% +0.1% 119.99 KB 120.05 KB 37.84 KB 37.87 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.72 KB 10.72 KB 3.66 KB 3.67 KB UMD_PROD
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.1% 2.83 KB 2.83 KB 1.32 KB 1.33 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.8 KB 59.8 KB 15.65 KB 15.66 KB NODE_DEV
react-dom-unstable-flight-server.browser.development.js 0.0% 0.0% 9.12 KB 9.12 KB 3 KB 3.01 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.21 KB 137.21 KB 36.03 KB 36.03 KB NODE_DEV
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.53 KB 8.53 KB 2.54 KB 2.55 KB NODE_DEV
react-dom-test-utils.development.js 0.0% 0.0% 56.08 KB 56.08 KB 15.51 KB 15.51 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.26 KB 20.26 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.71 KB 2.71 KB 1.27 KB 1.27 KB NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.36 KB 54.36 KB 15.18 KB 15.18 KB NODE_DEV
react-dom-server.browser.development.js 0.0% 0.0% 140.17 KB 140.17 KB 36.81 KB 36.81 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 687 B 689 B NODE_PROD

ReactDOM: size: 0.0%, gzip: 🔺+0.1%

Size changes (stable)

Generated by 🚫 dangerJS against b84f028

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2019 •
edited
Loading

Re: async, I could follow this pattern:

react/packages/react-dom/src/client/ReactDOM.js

Lines 542 to 549 in be3bfa6

// Unmount should not be batched.
unbatchedUpdates(() => {
legacyRenderSubtreeIntoContainer(null, null, container, false, () => {
container._reactRootContainer = null;
});
});
// If you call unmountComponentAtNode twice in quick succession, you'll
// get `true` twice. That's probably fine?

@gaearon gaearon merged commit a7b4d51 into facebook:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @sebmarkbage @facebook-github-bot