Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when createRoot() is called on existing root #17328

Closed
wants to merge 1 commit into from
Closed

Warn when createRoot() is called on existing root #17328

wants to merge 1 commit into from

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 9, 2019 •
edited
Loading

The behavior is pretty confusing: https://codesandbox.io/s/frosty-satoshi-z87yi

So this adds a warning. Will be useful to people who replace .render() with .createRoot().render() without considering that they may be running it multiple times.

I don't warn if you .unmount() first. That seems okay-ish. Maybe you really don't have access to the root instance but at least you can free the previous one.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b26e71:

Sandbox Source
elated-booth-y3olr Configuration
compassionate-roentgen-pixmr PR

@sebmarkbage
Copy link
Collaborator

We attach another container flag for purposes for the event system to know if we’re in a react root.

Can we reuse that?

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 9, 2019

Yeah I can unify them. That would also solve the iOS issue.

@sizebot
Copy link

sizebot commented Nov 9, 2019

Details of bundled changes.

Comparing: be3bfa6...7b26e71

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.46 KB 10.46 KB 3.56 KB 3.57 KB NODE_PROD
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.2% 2.64 KB 2.64 KB 1.25 KB 1.25 KB NODE_PROD
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.7 KB 8.7 KB 2.59 KB 2.59 KB UMD_DEV
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.88 KB 2.88 KB 1.33 KB 1.34 KB UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 136.1 KB 136.1 KB 35.81 KB 35.81 KB NODE_DEV
react-dom-unstable-flight-server.node.development.js 0.0% +0.1% 10.02 KB 10.02 KB 3.26 KB 3.26 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 951.9 KB 952.29 KB 215.24 KB 215.31 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.85 KB 19.85 KB 7.38 KB 7.38 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom-unstable-flight-server.node.production.min.js 0.0% 🔺+0.2% 2.8 KB 2.8 KB 1.27 KB 1.28 KB NODE_PROD
react-dom.production.min.js 0.0% 0.0% 116.16 KB 116.16 KB 37.43 KB 37.43 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.4% 1.2 KB 1.2 KB 700 B 703 B UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 119.73 KB 119.73 KB 38.49 KB 38.49 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 946.01 KB 946.4 KB 213.66 KB 213.74 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.7 KB 3.7 KB 1.49 KB 1.49 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 116.3 KB 116.3 KB 36.79 KB 36.79 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.5% 1.04 KB 1.04 KB 631 B 634 B NODE_PROD
react-dom-unstable-flight-server.browser.development.js 0.0% +0.1% 9.32 KB 9.32 KB 3.06 KB 3.06 KB UMD_DEV
react-dom.profiling.min.js 0.0% 0.0% 119.99 KB 119.99 KB 37.84 KB 37.84 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.72 KB 10.72 KB 3.66 KB 3.67 KB UMD_PROD
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.2% 2.83 KB 2.83 KB 1.32 KB 1.33 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.8 KB 59.8 KB 15.65 KB 15.66 KB NODE_DEV
react-dom-unstable-flight-server.browser.development.js 0.0% +0.1% 9.12 KB 9.12 KB 3 KB 3.01 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.21 KB 137.21 KB 36.03 KB 36.03 KB NODE_DEV
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.53 KB 8.53 KB 2.54 KB 2.55 KB NODE_DEV
react-dom-test-utils.development.js 0.0% 0.0% 56.08 KB 56.08 KB 15.51 KB 15.51 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.26 KB 20.26 KB 7.53 KB 7.53 KB NODE_PROD
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.71 KB 2.71 KB 1.27 KB 1.27 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.36 KB 54.36 KB 15.18 KB 15.18 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.4 KB 4.4 KB 1.64 KB 1.64 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 140.17 KB 140.17 KB 36.81 KB 36.81 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.2 KB 1.2 KB 687 B 689 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 19.93 KB 19.93 KB 7.38 KB 7.39 KB UMD_PROD

ReactDOM: size: 0.0%, gzip: 🔺+0.1%

Size changes (stable)

Generated by 🚫 dangerJS against 7b26e71

@sizebot
Copy link

sizebot commented Nov 9, 2019

Details of bundled changes.

Comparing: be3bfa6...7b26e71

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 123.54 KB 123.54 KB 38.79 KB 38.79 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140.2 KB 140.2 KB 36.81 KB 36.81 KB UMD_DEV
react-dom-unstable-flight-server.browser.development.js 0.0% 0.0% 9.34 KB 9.34 KB 3.06 KB 3.06 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.39 KB 20.39 KB 7.48 KB 7.48 KB UMD_PROD
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.1% 2.85 KB 2.85 KB 1.33 KB 1.33 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 56.1 KB 56.1 KB 15.52 KB 15.52 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.72 KB 8.72 KB 2.59 KB 2.6 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.4% 1.21 KB 1.21 KB 708 B 711 B UMD_PROD
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.1% 2.89 KB 2.89 KB 1.34 KB 1.34 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 139.57 KB 139.57 KB 35.4 KB 35.4 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% 0.0% 54.37 KB 54.37 KB 15.18 KB 15.18 KB NODE_DEV
ReactDOMServer-prod.js 0.0% 0.0% 48.79 KB 48.79 KB 11.13 KB 11.13 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-unstable-flight-client.development.js 0.0% +0.1% 8.54 KB 8.54 KB 2.55 KB 2.55 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.5% 1.05 KB 1.05 KB 639 B 642 B NODE_PROD
react-dom-unstable-flight-client.production.min.js 0.0% 🔺+0.2% 2.72 KB 2.72 KB 1.28 KB 1.28 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 951.92 KB 952.31 KB 215.26 KB 215.34 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.57 KB 119.57 KB 38.35 KB 38.35 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 123.25 KB 123.25 KB 39.44 KB 39.45 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 946.03 KB 946.42 KB 213.68 KB 213.76 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.24 KB 137.24 KB 36.03 KB 36.03 KB NODE_DEV
react-dom-unstable-flight-server.node.development.js 0.0% +0.1% 10.03 KB 10.03 KB 3.27 KB 3.27 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.74 KB 119.74 KB 37.73 KB 37.74 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.72 KB 20.72 KB 7.61 KB 7.61 KB NODE_PROD
react-dom-unstable-flight-server.node.production.min.js 0.0% 🔺+0.2% 2.81 KB 2.81 KB 1.28 KB 1.29 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 136.13 KB 136.13 KB 35.81 KB 35.81 KB NODE_DEV
react-dom-unstable-flight-server.browser.development.js 0.0% +0.1% 9.13 KB 9.13 KB 3.01 KB 3.02 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.31 KB 20.31 KB 7.46 KB 7.46 KB NODE_PROD
react-dom-unstable-flight-server.browser.production.min.js 0.0% 🔺+0.2% 2.65 KB 2.65 KB 1.26 KB 1.26 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.14 KB 60.14 KB 15.79 KB 15.8 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.73 KB 10.73 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 974.39 KB 974.84 KB 216.25 KB 216.33 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 402.36 KB 402.36 KB 73.11 KB 73.11 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.82 KB 59.82 KB 15.66 KB 15.66 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 403.2 KB 403.2 KB 73.67 KB 73.67 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.48 KB 10.48 KB 3.57 KB 3.58 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.4% 1.21 KB 1.21 KB 695 B 698 B NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 7b26e71

@gaearon gaearon mentioned this pull request Nov 10, 2019
Merged
@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2019

#17329

@gaearon gaearon closed this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

@bvaughn bvaughn Awaiting requested review from bvaughn

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sebmarkbage @sizebot @facebook-github-bot