Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ReactNativeART arc drawing on Android #5856

Closed
wants to merge 3 commits into from
Closed

fix ReactNativeART arc drawing on Android #5856

wants to merge 3 commits into from

Conversation

dgladkov
Copy link
Contributor

This patch fixes multiple problems with arc drawing on Android and makes it consistent with how CGPathAddArc works on iOS

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @spicyj and @lexs to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Feb 10, 2016
@facebook-github-bot
Copy link
Contributor

@dgladkov updated the pull request.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@dgladkov updated the pull request.

@facebook-github-bot
Copy link
Contributor

@dgladkov updated the pull request.

@satya164
Copy link
Contributor

cc @mkonicek

@dgladkov
Copy link
Contributor Author

This problem can be reproduced when using react-art's Wedge shape (https://github.com/reactjs/react-art/blob/master/src/Wedge.art.js). I can create a sample RN project that illustrates the error if needed.

@satya164
Copy link
Contributor

@dgladkov A sample would be great. Thanks.

@dgladkov
Copy link
Contributor Author

Created a project to illustrate the bug https://github.com/dgladkov/RNArtArcDrawingBug
Check the README for screenshots of iOS and Android rendeirng

@oblador oblador mentioned this pull request Mar 30, 2016
Closed
@dgladkov
Copy link
Contributor Author

Fixes #5311

@mkonicek
Copy link
Contributor

What's the test plan? Do you have some screenshots before / after?

@ghost
Copy link

ghost commented Apr 2, 2016

@spicyj would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

@mkonicek
Copy link
Contributor

mkonicek commented Apr 7, 2016

@dgladkov Can you add some screenshots please so we can see what it looks like?

@MikeOrtiz
Copy link
Contributor

@mkonicek The author added 'before' screenshots illustrating the bug here: https://github.com/dgladkov/RNArtArcDrawingBug

Do you need @dgladkov to add 'after' screenshots as well?

@MikeOrtiz
Copy link
Contributor

This PR had a bug in it. I submitted my own, including screenshots: #7049.

@mkonicek
Copy link
Contributor

@MikeOrtiz We could merge #7049, it's being reviewed now.

@mkonicek
Copy link
Contributor

Created a project to illustrate the bug https://github.com/dgladkov/RNArtArcDrawingBug

Oh sorry @dgladkov I didn't see that, I look for a Test plan in the pull request summary, see https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md

@MikeOrtiz
Copy link
Contributor

@mkonicek This PR can be closed now that #7049 was accepted.

@mkonicek
Copy link
Contributor

Thanks for the update @MikeOrtiz!

@mkonicek mkonicek closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgladkov @facebook-github-bot @satya164 @mkonicek @MikeOrtiz