Implementation of ART.Path.arcTo on Android Renders Incorrectly

[hswolff]

I'm trying to dynamically draw an arc in my react-native application using ART (which is awesome btw).

What I've found is that the Android implementation of arcTo behaves widely different than the iOS implementation, with the same JS code powering it.

I've created a test case for this issue that you can easily add to your application to see the differences.

Running the above code on iOS produces:

Running the above code on Android produces:

For curiosity's sake I changed line 46 from arcTo to lineTo.

That produced the following on iOS:

And the following on Android:

I imagine the issue resets somewhere in here https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/views/art/ARTShapeShadowNode.java#L228-L243 however would love some input.

[facebook-github-bot]

Hey hswolff, thanks for reporting this issue!

React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

• If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
• If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
• We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!

[hswolff]

This is version of react 0.18.0-rc FYI.

[gadiel]

@hswolff can you describe how you managed to get ReactArt running on Android?
tried
"Tested in open source by adding a import com.facebook.react.ARTPackage; and .addPackage(new ARTPackage()) to UIExplorerActivity.java, running"

no luck

[hswolff]

@gadiel that line isn't necessary, just be sure you're running at least 0.18.0-rc and it worked out of the box for me.

[rops]

+1

[ol2dd]

+1

[mehdichamouma]

Should this issue be closed by this PR ?
#7049

[doddys]

the problem still persists in RN 0.28

[robclouth]

And in RN 0.33

[lacker]

It seems like there are some different bugs being discussed here because #7049 fixed some but not all things. I think we should close this particular issue but if people are still running into ART + Android + arc problems it would be great to get new issues filed, ideally with rnplay.org links too. Thanks for helping out folks!