-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule #39682
Conversation
This pull request was exported from Phabricator. Differential Revision: D49523696 |
Base commit: e1d824f |
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: c4c052b39bf0ca2c41c4eeb0803dc9fa9fc44d13
566a19d
to
6f209c1
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 27f52fe752a44de0e8bfe790e4f7c7a0cb2a544f
6f209c1
to
2faf41a
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 4e955f7a0847e1f8916287ca8d5a620868327658
2faf41a
to
af7cb2e
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 2eea1170ab280ebdec8cf6374d312ee3ff7341af
af7cb2e
to
75138b4
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 14a423fbaaa73bf099ea1882543350e338391b8d
75138b4
to
a34c756
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: d49e0a1be6a76f9f606efb7d1c61b05fbc38a8b8
a34c756
to
c77839e
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 6bbaa6b27977ed5b9fa263cdcd876ebdcbe4a62d
c77839e
to
b60d990
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: bee4dad68f779efb820c252b4e4dd2142ea5a2b3
b60d990
to
0b9f1d0
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: fb713cfb0f141422ebff685cbd0f4936ba7572ed
0b9f1d0
to
530631a
Compare
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: e170683a47eaedd028847b8d4d23f70e8b48be44
530631a
to
b147838
Compare
Summary: Move ReactHost to com.facebook.react chnagelog: [internal] internal Differential Revision: D49834870 fbshipit-source-id: e677fd19d00f4ba779fb277d69dd09f1d3952372
Summary: In this diff I'm removing TurboModuleManager from ReactHostDelegate. The goal is to stop exposing TurboModuleManager and TurboModuleRegistry Developers should use ReactContext.getNativeModule to retrieve native modules instead of TurboModuleManager or TurboModuleRegistry changelog: [internal] internal Differential Revision: D49483636 fbshipit-source-id: b3065f711a67272976751590d9bdc5339c99b439
This pull request was exported from Phabricator. Differential Revision: D49523696 |
…react.internal.turbomodule (facebook#39682) Summary: Pull Request resolved: facebook#39682 Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule changelog: [internal] internal Reviewed By: RSNara Differential Revision: D49523696 fbshipit-source-id: 495b5dab52026c7182ca81023eaa4c11401b2081
b147838
to
5fa9071
Compare
This pull request was successfully merged by @mdvacca in b7191cd. When will my fix make it into a release? | Upcoming Releases |
This pull request has been merged in b7191cd. |
…odule.kt Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
…odule.kt (facebook#41412) Summary: The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413
…odule.kt (#41412) Summary: Pull Request resolved: #41412 The PR #39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413 fbshipit-source-id: 921475f4beee7c6f04912558204a1911cd74b5ca
…odule.kt (facebook#41412) Summary: Pull Request resolved: facebook#41412 The PR facebook#39682 moved all TurboModule classes into the folder com/facebook/react/internal/turbomodule/core/interfaces/TurboModule. The reasoning is TurboModule classes are internal implementation of RN and they shouldn't be part of the public API. Later we realized that com.facebook.react.internal.turbomodule.core.interfaces.TurboModule interface is actually being used by OSS developers too implement the TurboReactPackage.getReactModuleInfoProvider() method: https://reactnative.dev/docs/next/the-new-architecture/pillars-turbomodules#updating-the-calculatorpackagejava In this diff I'm re-introducing the com.facebook.react.turbomodule.core.interfaces.TurboModule interface jus for backward compatibility. Since the plan is to delete the TurboReactPackage.getReactModuleInfoProvider method in the next few months, the plan is: - Iterate on the experiments to remove TurboReactPackage.getReactModuleInfoProvider method - Once TurboReactPackage.getReactModuleInfoProvider method is ready to be deleted, there's no need to expose TurboModule interface anymore, so we will delete 'com.facebook.react.turbomodule.core.interfaces.TurboModule' and 'TurboReactPackage.getReactModuleInfoProvider' method - com.facebook.react.internal.turbomodule.core.interfaces.TurboModule will still remain in the codebase, but this will be an internal API changelog: [Android][Changed] Fix backward compatibility breakage Reviewed By: fkgozali Differential Revision: D51168413 fbshipit-source-id: 921475f4beee7c6f04912558204a1911cd74b5ca
Summary: Move TurboModule from com.facebook.react.turbomodule -> com.facebook.react.internal.turbomodule
Reviewed By: RSNara
Differential Revision: D49523696