Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to build reanimated with latest react due to turbo module classes removal #5574

Closed
Icehunter opened this issue Jan 11, 2024 · 8 comments
Labels
Missing repro This issue need minimum repro scenario Platform: Android This issue is specific to Android

Comments

@Icehunter
Copy link

Description

React Native starting with the 0.74 nighties has removed the classes for TurboModules and made them internal.

facebook/react-native#39682

With this change, I am unable to use the library with latest RN.

node_modules/react-native-reanimated/android/src/paper/java/com/swmansion/reanimated/NativeProxy.java:9: error: package com.facebook.react.turbomodule.core does not exist
import com.facebook.react.turbomodule.core.CallInvokerHolderImpl

Steps to reproduce

  1. setup any sample app with react-native@nightly along with latest reanimated
  2. try to build

Snack or a link to a repository

facebook/react-native#39682

Reanimated version

3.6.1

React Native version

0.74-0 nightly

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

Fabric (New Architecture)

Build type

Release app & production bundle

Device

Real device

Device model

No response

Acknowledgements

Yes

@github-actions github-actions bot added Platform: Android This issue is specific to Android Missing repro This issue need minimum repro scenario labels Jan 11, 2024
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@Icehunter Icehunter reopened this Jan 11, 2024
@Icehunter
Copy link
Author

Wrong button sorry. It's still issue with @next as well.

@zahidhussain998
Copy link

yep still issue is but i'm trying to solve it

@piaskowyk
Copy link
Member

Hey, we haven't been supporting RN@0.74 :/ We are working on it here - #5328

@Rexogamer
Copy link

any news on RN 0.74 support? facing a different error and saw this; the linked PR was closed without merging and I can't seem to find anything else about 0.74

@Gu1K
Copy link

Gu1K commented Apr 4, 2024

same

@Rexogamer
Copy link

another pr was opened and merged, so it should just be a matter of cutting a new release

@Rexogamer
Copy link

fixed in v3.9.0-rc.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro This issue need minimum repro scenario Platform: Android This issue is specific to Android
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants