Remove unused files from inspector-modern #39364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
Base commit: 6991db0 |
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: f6807921a5f656277e28c27fa3fd93050e2dbf05
3845aec to
88a98c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: 73e7f439576dba4d8d1e54c96654bfce9e1e627f
88a98c1 to
d8160a0
Compare
cipolleschi
pushed a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: 35c9c3f9d38c3c8d927573d196a3f27e5dac2ceb
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: 95aa4a1916a7d3e1b2a90a2f4d83f71900bc19cb
d8160a0 to
60d0735
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: 0eb6bf8628acaf4c7a7fbc5ea5c3088c537404af
60d0735 to
a3dd26f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
a3dd26f to
2a7f117
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: 56999110cbe024d55f9cf8d985e1ca9927980a8a
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: f0aaa4497e5ca5a03cc7019b7b96a3f2a383793e
2a7f117 to
ef2259d
Compare
Summary: Pull Request resolved: facebook#39364 Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed. Changelog: [Internal] Reviewed By: mattbfb Differential Revision: D49073914 fbshipit-source-id: d55c2f4a0eb6030f053234d85d9a16d2307b2eb1
|
This pull request was exported from Phabricator. Differential Revision: D49073914 |
ef2259d to
49ea6ea
Compare
|
This pull request was successfully merged by @motiz88 in 70c77f4. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed.
Changelog: [Internal]
Reviewed By: mattbfb
Differential Revision: D49073914