Skip to content

Commit

Permalink
Remove unused files from inspector-modern (#39364)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39364

Once ConnectionDemux.* and Registration.* finish migrating to the new Hermes CDPHandler, there aren't any usage of the other stuff left over in inspector-modern. They can be safely removed.

Changelog: [Internal]

Reviewed By: mattbfb

Differential Revision: D49073914

fbshipit-source-id: bc60a3da85a00ac86beeebd098d7c3566a7c56dd
  • Loading branch information
motiz88 authored and facebook-github-bot committed Oct 16, 2023
1 parent 6991db0 commit 70c77f4
Show file tree
Hide file tree
Showing 36 changed files with 1 addition and 9,087 deletions.
2 changes: 0 additions & 2 deletions packages/react-native/ReactCommon/hermes/React-hermes.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ Pod::Spec.new do |s|
s.platforms = min_supported_versions
s.source = source
s.source_files = "executor/*.{cpp,h}",
"inspector-modern/*.{cpp,h}",
"inspector-modern/chrome/*.{cpp,h}",
"inspector-modern/detail/*.{cpp,h}"
s.public_header_files = "executor/HermesExecutorFactory.h"
s.compiler_flags = folly_compiler_flags + ' ' + boost_compiler_flags
s.pod_target_xcconfig = {
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
cmake_minimum_required(VERSION 3.13)
set(CMAKE_VERBOSE_MAKEFILE on)

file(GLOB hermesinspectormodern_SRC CONFIGURE_DEPENDS *.cpp detail/*.cpp chrome/*.cpp)
file(GLOB hermesinspectormodern_SRC CONFIGURE_DEPENDS chrome/*.cpp)

add_library(hermes_inspector_modern
STATIC
Expand All @@ -15,7 +15,6 @@ add_library(hermes_inspector_modern
target_compile_options(
hermes_inspector_modern
PRIVATE
-DHERMES_INSPECTOR_FOLLY_KLUDGE=1
-std=c++20
-fexceptions
)
Expand All @@ -32,9 +31,6 @@ target_include_directories(hermes_inspector_modern PUBLIC ${REACT_COMMON_DIR})
target_link_libraries(hermes_inspector_modern
jsinspector
fb
fbjni
folly_futures
folly_runtime
glog
hermes-engine::libhermes
jsi)

This file was deleted.

Loading

0 comments on commit 70c77f4

Please sign in to comment.