-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: bump AGP to 7 #32589
draft: bump AGP to 7 #32589
Conversation
Base commit: 26e30a5 |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
I believe you have to unset |
We need to update the docker image to fix the issue. |
@lunaleaps Just as a FYI for you, this will make Java 11 a requirement for users that are either:
So as soon as this gets merged, we might want to highlight this in the release notes somewhere. |
@cortinico This should be for 68 right? I think we should add this kind of information to changelog? Or maybe there needs to be a new type of notice like: [Release Notes] or something that we can pull out to put into a blog post |
Correct.
I'd say this should go both in the changelog and in the blogpost that is coming with this release. As a side note: we should also merge those two |
@cortinico CI is failing, but I couldn't reproduce it on my local machine. Please help |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
To reproduce you can You should be able to fix it by adding:
inside the |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sadly it's still failing with a similar issue on the RNTester App |
@cortinico has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Base commit: 26e30a5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pudate: So this PR is good to land from my point of view. @dulmandakh I've pushed to commits that fixed the failures. Let me know if you're fine with them.
There are also a couple of fixes we need to apply internally to make sure the internal CI is also Green, so it could take a bit longer to land this PR (just as a FYI).
As a follow-up: this is the bug on AGP's end: https://issuetracker.google.com/issues/207403732 |
@cortinico merged this pull request in 272cfe5. |
Summary: Bump Android Gradle Plugin to 7. ## Changelog [Android] [Changed] - Bump Android Gradle Plugin to 7. This will make Java 11 a requirement for users that are either: * Cloning react-native to contribute * Using react-native while building from source. * Creating new project from the template. Pull Request resolved: facebook#32589 Test Plan: CI is green Reviewed By: ShikaSD Differential Revision: D32427945 Pulled By: cortinico fbshipit-source-id: c1ea464d87c3e397616c55154b3d8b1c3ea6c592
Summary
Bump Android Gradle Plugin to 7.
Changelog
[Android] [Changed] - Bump Android Gradle Plugin to 7.
This will make Java 11 a requirement for users that are either:
Test Plan
CI is green