Skip to content

Commit

Permalink
Fix incorrect ViewFlattening for views that were listening for a JS e…
Browse files Browse the repository at this point in the history
…vent

Summary:
This diff prevents view flattening for views that are handling some events in the JS side

changelog: [internal] internal

Reviewed By: javache

Differential Revision: D32253124

fbshipit-source-id: acda2b12287f0a9c39a810b23a101765093ba217
  • Loading branch information
mdvacca authored and facebook-github-bot committed Nov 19, 2021
1 parent 34a5158 commit 26e30a5
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions ReactCommon/react/renderer/components/view/ViewShadowNode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@ void ViewShadowNode::initialize() noexcept {

bool formsStackingContext = !viewProps.collapsable ||
viewProps.pointerEvents == PointerEventsMode::None ||
!viewProps.nativeId.empty() || viewProps.accessible ||
viewProps.opacity != 1.0 || viewProps.transform != Transform{} ||
viewProps.elevation != 0 ||
viewProps.onLayout || viewProps.pointerEnter || viewProps.pointerLeave ||
viewProps.pointerMove || !viewProps.nativeId.empty() ||
viewProps.accessible || viewProps.opacity != 1.0 ||
viewProps.transform != Transform{} || viewProps.elevation != 0 ||
(viewProps.zIndex.has_value() &&
viewProps.yogaStyle.positionType() != YGPositionTypeStatic) ||
viewProps.yogaStyle.display() == YGDisplayNone ||
Expand Down

0 comments on commit 26e30a5

Please sign in to comment.