Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SafeAreaView to ES Module #31344

Closed
wants to merge 1 commit into from
Closed

Convert SafeAreaView to ES Module #31344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Components/SafeAreaView/SafeAreaView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ if (Platform.OS === 'android') {
);
}

module.exports = exported;
export default exported;
Copy link
Contributor

@lunaleaps lunaleaps Apr 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe it's clearer to rename this to SafeAreaView?

2 changes: 1 addition & 1 deletion Libraries/Components/SafeAreaView/__tests__/SafeAreaView-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
'use strict';

const React = require('react');
const SafeAreaView = require('../SafeAreaView');
import SafeAreaView from '../SafeAreaView';
const ReactNativeTestTools = require('../../../Utilities/ReactNativeTestTools');
const View = require('../../View/View');
const Text = require('../../../Text/Text');
Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ module.exports = {
return require('./Libraries/Components/RefreshControl/RefreshControl');
},
get SafeAreaView(): SafeAreaView {
return require('./Libraries/Components/SafeAreaView/SafeAreaView');
return require('./Libraries/Components/SafeAreaView/SafeAreaView').default;
},
get ScrollView(): ScrollView {
return require('./Libraries/Components/ScrollView/ScrollView');
Expand Down