Convert SafeAreaView to ES Module #31344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base commit: a15a46c |
lunaleaps
approved these changes
Apr 14, 2021
| @@ -58,4 +58,4 @@ if (Platform.OS === 'android') { | |||
| ); | |||
| } | |||
|
|
|||
| module.exports = exported; | |||
| export default exported; | |||
There was a problem hiding this comment.
nit: maybe it's clearer to rename this to SafeAreaView?
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@lunaleaps merged this pull request in d9a86aa. |
|
Thanks @franzon for your contribution! |
|
Sorry accidentally clicked "Reopen and comment" lol |
Kudo
pushed a commit
to Kudo/react-native
that referenced
this pull request
Apr 16, 2021
Summary: Convert SafeAreaView to ES Module (facebook#31330). ## Changelog [General] [Changed] - Converted `SafeAreaView` to ES Module. Pull Request resolved: facebook#31344 Test Plan: Tested that `npm test` passes. Reviewed By: kacieb Differential Revision: D27767463 Pulled By: lunaleaps fbshipit-source-id: fd3aee58ae6d621a292ff3360d8833f5e5007d52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert SafeAreaView to ES Module (#31330).
Changelog
[General] [Changed] - Converted
SafeAreaViewto ES Module.Test Plan
Tested that
npm testpasses.