Adding pod target config to yoga to solve warning.
#17722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact-native` of `0.52.1` with `cocoapods` .
Warning:
```
/Users/OceanHorn/ReactNative/demo0124/Demo/node_modules/react-native/ReactCommon/Yoga/yoga/YGNodePrint.cpp:208:46: error: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int') [-Werror,-Wshorten-64-to-32]
const uint32_t childCount = node->children.size();
~~~~~~~~~~ ~~~~~~~~~~~~~~~^~~~~~
1 error generated.
```
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Why shouldn't we fix this warning (potential error in Yoga) instead? |
|
Please do not hide the error instead of solving it! |
|
It seems to be no longer relevant after v0.52.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding pod target config to
yogato solve warning when integratereact-nativeof0.52.1withcocoapods.Warning:
Motivation
Solve warning when integrate
react-native0.52.1withcocoapods.Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/react-native-website, and link to your PR here.)
Release Notes
[IOS] [BUGFIX] [Yoga] - Added a target config.