0.52.0-rc.0: Yoga Value Conversion Issue preventing build #17274

jaysig · 2017-12-19T16:06:37Z

Is this a bug report?

Yes

Have you read the Contributing Guidelines?

Yes

Environment

Steps to Reproduce

(Write your steps here:)

Try to build app in xCode
Receive Error Implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int')
line 208 in YGNodePrint.cpp const uint32_t childCount = node->children.size();

Not sure if this is related but Line 201 and 293 of Yoga.cpp are also throwing logic errors of Null pointer argument in call to memory copy function

Expected Behavior

I expected my app to work. It had hung up at the splash screen with no errors except the yoga logic errors and I assumed the newer version would resolve them.

Actual Behavior

The app is unable to build due to the yoga issue and xCodes says there are two other logic errors in Yoga.

Reproducible Demo

I would imagine this would just show up in any new project; however, any suggested steps to resolve it would be appreciated.

The text was updated successfully, but these errors were encountered:

shameemz · 2017-12-20T04:00:47Z

Facing the same issue after upgrading to 0.52.0-rc.0.

jcady · 2017-12-20T21:35:23Z

I'm seeing this same issue in Xcode 9.2 with 0.52.0-rc.0.

hpb0412 · 2018-01-02T09:06:42Z

The same thing happened for me on Xcode 9.2 (9C40b) with yoga 0.52.0-rc.0 (after update to react-native@0.52.0-rc.0)

blackxored · 2018-01-05T15:05:09Z

It is not fixed on master either.

gabrielbull · 2018-01-08T15:28:40Z

Version 0.52.0 was released with this bug still present. I bet there's going to be an influx of people having this issue now. We really should have resolved this issue before releasing 0.52.0 😬.

gabrielbull · 2018-01-08T15:31:49Z

Let's bring in @priteshrnandgaonkar into this discussion as he's the one who worked on the file causing issues.

turnrye · 2018-01-08T15:33:28Z

b08a912 would be the commit I believe

priteshrnandgaonkar · 2018-01-08T16:36:14Z

I ran RNTester shipped with RC. It built and ran successfully. The messages which are mentioned above are just warnings, those shouldn't be the cause of the problem. Although I will fix those warnings

fungilation · 2018-01-09T01:05:38Z

@gabrielbull I confirm Xcode build stalled at this exact same line with same error, in YGNodePrint.cpp, on RN 0.52.0. How/Why did RN release ship with a glaring show stopper again like this is a good question. 😭

Any idea for a workaround?

LeVadim · 2018-01-09T01:17:53Z

Same issue here, it won't build due to this error

kontinuity · 2018-01-09T06:50:31Z


❌  ...node_modules/react-native/ReactCommon/yoga/yoga/YGNodePrint.cpp:208:46: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int') [-Werror,-Wshorten-64-to-32]

  const uint32_t childCount = node->children.size();
              ^~~~~~


▸ Compiling yoga-dummy.m
▸ Compiling Yoga.cpp
** ARCHIVE FAILED **


The following build commands failed:
	CompileC ...Library/Developer/Xcode/DerivedData/xxxx-eouawjjkefabkkexnsxilamhdmzd/Build/Intermediates.noindex/ArchiveIntermediates/xxxx-Release/IntermediateBuildFilesPath/Pods.build/Release-iphoneos/yoga.build/Objects-normal/arm64/YGNodePrint.o ...node_modules/react-native/ReactCommon/yoga/yoga/YGNodePrint.cpp normal arm64 c++ com.apple.compilers.llvm.clang.1_0.compiler

The build fails due to this fatal error.

hanweixing · 2018-01-09T06:58:34Z

Got this too. Mark this issue, expect solutions soon.

bkitduy · 2018-01-09T08:26:39Z

Fix please :(. I'm facing this issue (React 0.52.0 - yoga 0.52.0)

hitbear518 · 2018-01-09T09:31:08Z

Same issue. Integrated with existing app, upgraded from 0.50.4

raviatflexiloans · 2018-01-09T09:55:01Z

Facing the same issues. Getting following error:

error: implicit conversionloses integer precision: 'size_type' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
return node->children.size();

Summary: There were warnings of castings and null pointer handling in yoga.cpp. This diff fixes the warnings. The issue was brought up here facebook/react-native#17274 Reviewed By: emilsjolander Differential Revision: D6675111 fbshipit-source-id: 884659fabb05033b4d43d3aa6629e22481d39b7e

allthetime · 2018-01-09T13:29:13Z

How can I incorporate these new changes?

vovkasm · 2018-01-09T14:43:25Z

People!

Dev process

This issue was opened before 0.52.0 release, how and why release happened? What was/will be done to not repeat this in future?

Technical

The messages which are mentioned above are just warnings, those shouldn't be the cause of the problem.

They are not "just warnings", they signs of holes in logic or design, inconsistency in type systems or other flawless. But this other story, same as transit yoga to C++... there are so many pitfalls only to allow inlining of methods :-/

I had to say this.
C/C++ code in RN will be compiled on various platforms with many-many various settings. E.g. android with two build systems (buck/ndk, right?), ios with two build systems: standard, by inclusion of React.xcodeproj etc... and cocoapods, cocoapods generates own xcodeproj files, so settings for C/C++ files are different.
Take all these variants, I can suggest to:

Make C/C++ code maximum clean and warning free.
Identify all build variants/systems and test build automatically with these variants.
Make it clear in docs about required build settings and/or create some single place to store this settings and tool to update it in build files?

vovkasm · 2018-01-09T15:37:35Z

Addition to previous:

To workaround -Werror settings for yoga (only RN integrated with cocoapods), add this to Podfile:

post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == 'yoga'
            target.build_configurations.each do |config|
                config.build_settings['GCC_TREAT_WARNINGS_AS_ERRORS'] = 'NO'
            end
        end
    end
end

But I make it only to find #17027 :-(

Jono20201 · 2018-01-09T16:26:47Z

Same issue.

guysegal · 2018-01-09T17:07:43Z

I'm also getting Yoga related errors on iOS compilation, see:

and:

is it related?

vovkasm · 2018-01-09T17:25:20Z

@guysegal this most probably not related, this is more like integration problems. If you use cocoapods, may be this helps. If you use vanilla react-native project, I can suggest to generate new empty project and compare Xcode project settings, most notable schema settings.

ma-pe · 2018-01-09T17:34:56Z

Downgrading to React-Native 0.50 worked for me as a "work-around".

edit: 0.51 also works fine.

fungilation · 2018-01-09T17:49:02Z

Downgrading to React-Native 0.50.0 worked for me as a work-around.

Considering I upgraded from RN 0.51, that's not a workaround, that's giving up. 😭

gabrielbull · 2018-01-09T17:51:29Z

@fungilation Haha, you can downgrade to 0.51 as well, this issue is specific to 0.52.0. We'll need to wait for 0.52.1 to update.

fungilation · 2018-01-09T17:52:55Z

@vovkasm, that's unrelated. I already have this in my Podfile:

pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

@gabrielbull this is most appropriate.

dluksza · 2018-01-09T17:58:08Z

In my case, I also need to disable GCC_WARN_64_TO_32_BIT_CONVERSION for yoga and now my project compiles and runs perfectly.

The full workaround for this issue if you are using cocoapods:

post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == 'yoga'
            target.build_configurations.each do |config|
                config.build_settings['GCC_TREAT_WARNINGS_AS_ERRORS'] = 'NO'
                config.build_settings['GCC_WARN_64_TO_32_BIT_CONVERSION'] = 'NO'
            end
        end
    end
end

msand · 2018-01-18T16:58:54Z

@tonygriv @itinance Make sure your Podfile contains both the tvOS bug workaround:
https://github.com/msand/SVGPodTest/blob/fe45f88a936181e6ecaddeb68268d33268b56121/ios/Podfile#L19
and the workaround for this bug:
https://github.com/msand/SVGPodTest/blob/fe45f88a936181e6ecaddeb68268d33268b56121/ios/Podfile#L56-L65

antonsivogrivov · 2018-01-19T09:41:26Z

@msand, adding this

config.build_settings['GCC_TREAT_WARNINGS_AS_ERRORS'] = 'NO'
config.build_settings['GCC_WARN_64_TO_32_BIT_CONVERSION'] = 'NO'

in podfile helps me, but is it a good solution?

msand · 2018-01-19T19:00:07Z

@tonygriv It complies, but, No. I think the upcoming fix is no good either. They should stick to the same number of bits everywhere, and not cast it, losing precision is guaranteed to cause bugs when someone puts a large enough input. There should be checks for too large inputs, independent of the chosen integer precision. And if 64 bit is allowed somewhere, it should be used everywhere along its read-write dependency graph.

OceanHorn · 2018-01-24T04:35:27Z

PR #17722 could also solve.

ahmetilhann · 2018-01-24T11:24:41Z

Example for podfile

# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'podExample' do
  # Uncomment the next line if you're using Swift or would like to use dynamic frameworks
  # use_frameworks!

  # Pods for podExample

  # Your 'node_modules' directory is probably in the root of your project,
  # but if not, adjust the `:path` accordingly
  pod 'React', :path => '../node_modules/react-native', :subspecs => [
    'Core',
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTText',
    'RCTNetwork',
    'RCTWebSocket', # needed for debugging
    # Add any other subspecs you want to use in your project
  ]
  
  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'GLog', :podspec => '../node_modules/react-native/third-party-podspecs/GLog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

end

post_install do |installer|
  installer.pods_project.targets.each do |target|
      if target.name == 'yoga'
          target.build_configurations.each do |config|
              config.build_settings['GCC_TREAT_WARNINGS_AS_ERRORS'] = 'NO'
              config.build_settings['GCC_WARN_64_TO_32_BIT_CONVERSION'] = 'NO'
          end
      end
  end
end

willbattel · 2018-01-25T00:47:41Z

Error is still present in 0.52.1. Any updates on an actual solution and not just temporary workarounds? 0.52 has been out for a while now and this issue is causing trouble for quite a few people.

hugomosh · 2018-01-25T00:55:01Z

I came here due to the react-native-maps iOS installation and this manage to do the work. And It works until I clean the project and did pod install again : )

# Uncomment the next line to define a global platform for your project
# platform :ios, '9.0'

target 'leoparkcityappv0' do
    rn_path = '../node_modules/react-native'
    rn_maps_path = '../node_modules/react-native-maps'
  
    #pod 'yoga', path: "#{rn_path}/ReactCommon/yoga/yoga.podspec" #From react-native-maps
    # Explicitly include Yoga if you are using RN >= 0.42.0
    pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

    pod 'React', path: rn_path, subspecs: [
      'Core',
      'RCTActionSheet',
      'RCTAnimation',
      'RCTGeolocation',
      'RCTImage',
      'RCTLinkingIOS',
      'RCTNetwork',
      'RCTSettings',
      'RCTText',
      'RCTVibration',
      'RCTWebSocket',
      'BatchedBridge',
      'tvOS', # https://github.com/facebook/react-native/issues/17274#issuecomment-356427445
    ]
  
    pod 'react-native-maps', path: rn_maps_path
  
    #pod 'GoogleMaps'  # Remove this line if you don't want to support Google Maps on iOS
    #pod 'react-native-google-maps', path: rn_maps_path  # Remove this line if you don't want to support Google Maps on iOS
  end
  
  post_install do |installer|
    installer.pods_project.targets.each do |target|
        if target.name == 'yoga'
            # Workaround: react-native v0.52 bug issue #17274
            # node_modules/react-native/ReactCommon/yoga/yoga/YGNodePrint.cpp:208:46: Implicit conversion loses integer
            # precision: 'size_type' (aka 'unsigned long') to 'const uint32_t' (aka 'const unsigned int')
            # https://github.com/facebook/react-native/issues/17274#issuecomment-356363557
            target.build_configurations.each do |config|
                config.build_settings['GCC_TREAT_WARNINGS_AS_ERRORS'] = 'NO'
                config.build_settings['GCC_WARN_64_TO_32_BIT_CONVERSION'] = 'NO'
            end
        end
      if target.name == 'react-native-google-maps'
        target.build_configurations.each do |config|
          config.build_settings['CLANG_ENABLE_MODULES'] = 'No'
        end
      end
      if target.name == "React"
        target.remove_from_project
      end
     
    end
  end

grabbou · 2018-01-25T23:46:54Z

@msand will do it right away.

maxkomarychev · 2018-01-26T08:52:10Z

@grabbou is there any reason why yoga sources are distributed within RN and not just referenced as dependency from it's origin repo?

grabbou · 2018-01-26T09:52:24Z

The main reason (as far as I am aware) is that at Facebook, everything lives in a single repository and so, all projects depend on "master".

When RN gets released in the open source, we have to "lock" its version so that we don't ship master-dependant build onto npm. To do so, one would need to make sure these two get released at the same time.

That's been the case of few issues with metro-bundler.

CC: @emilsjolander you might have a better idea here :)

grabbou · 2018-01-26T10:07:40Z

The commit has been cherry-picked and will be landing soon. Now, that the original issue has been fixed, I will close this one.

For any other, Yoga-specific requests (like this fix being inappropriate or not the most optimal way), please try opening a solution directly on Yoga repository.

msand · 2018-01-26T10:14:32Z

@grabbou Excellent, thank you!

guysegal · 2018-01-26T10:41:35Z

@grabbou just to be sure - after the fix do I still need hacks in the podfile to be able to compile?

grabbou · 2018-01-26T10:46:53Z

No - the code should be gone and so, no need to mute the warnings anymore :)

maxkomarychev · 2018-01-26T11:02:00Z

I installed latest release with "react-native": "git+https://github.com/facebook/react-native#v0.52.2" (since it's not available via npm yet)

And now I'm getting this:

❌  /Users/***/node_modules/react-native/ReactCommon/yoga/yoga/YGNodePrint.cpp:208:59: no member named 'getChildren' in 'YGNode'

  const uint32_t childCount = static_cast<uint32_t>(node->getChildren().size());
                                                    ~~~~  ^


▸ Compiling Yoga.cpp

❌  /Users/***/node_modules/react-native/ReactCommon/yoga/yoga/Yoga.cpp:474:38: no member named 'getChildren' in 'YGNode'

  return static_cast<uint32_t>(node->getChildren().size());
                               ~~~~  ^

can someone confirm you can compile?

maxkomarychev · 2018-01-26T12:23:12Z

Ok false alarm, I removed node_modules and installed everything from scratch. Able to compile now.

grabbou · 2018-01-26T12:37:21Z

Yeah, that was intermediate error - fixed it and that's why next install did the trick.

…

On Fri, 26 Jan 2018 at 13:24 maxkomarychev ***@***.***> wrote: Ok false alarm, I removed node_modules and installed everything from scratch. Able to compile now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17274 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxloA3GltTULxqwXyZZhJV0MTjPJ5ks5tOcPzgaJpZM4RHMA_> .

3degreeszw · 2018-02-27T05:49:38Z

1.$ npm i -g react-native-git-upgrade
2.inside your react-native project folder run
$ react-native-git-upgrade
3.delete ios/build, ios/Pods
4.$ cd ios && pod install
5.$ quite metro bundler if running
6.$ npm run ios

jayasimhaprasad · 2018-02-28T00:14:21Z

@3degreeszw your steps worked perfectly, thank you for posting it here

hegelstad · 2018-03-07T10:20:45Z

You are a savior @3degreeszw!

I had a problem with adding react-native-maps on top of react-native-firebase.

HemantRMali · 2018-03-10T06:28:01Z

Downgraded to "react-native": "^0.51.0", it seems stable version, and works fine
before that, i was using "react-native": "^0.54.0"

sadeshp · 2018-03-27T10:50:30Z

@grabbou The issue I am facing is adding use_framework! in podfile resulting into compile time error.
I am not able to build the project.

I am getting below errors.
#import <yoga/Yoga> -------> Could not build module Yoga.
#include -------> algorithm file not found.

I am using react-native 0.54.3 which is latest.

Does it mean, yoga is not supported when we use use_framework!?

Summary: There were warnings of castings and null pointer handling in yoga.cpp. This diff fixes the warnings. The issue was brought up here facebook/react-native#17274 Reviewed By: emilsjolander Differential Revision: D6675111 fbshipit-source-id: 884659fabb05033b4d43d3aa6629e22481d39b7e

rborn mentioned this issue Jan 9, 2018

Is a manual install possible (ios) react-native-maps/react-native-maps#1954

Closed

saghul mentioned this issue Jan 9, 2018

[RN] Update React Native to version 0.51.0 jitsi/jitsi-meet#2365

Merged

draperunner mentioned this issue Jan 19, 2018

Cannot upgrade to v2.3.0 because of use-frameworks! viromedia/viro#144

Closed

ulisinn mentioned this issue Jan 19, 2018

pod file: works with 5.5.1, fails with 6.0.1-rc.1 software-mansion/react-native-svg#572

Closed

grabbou closed this as completed Jan 26, 2018

thomashermine mentioned this issue Feb 6, 2018

AIRMap does not exist react-native-maps/react-native-maps#2005

Closed

apparition47 mentioned this issue Feb 7, 2018

Revert "Fix ambiguous resolution with react-native module (#266)" beefe/react-native-picker#274

Open

facebook locked as resolved and limited conversation to collaborators Jan 26, 2019

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jan 26, 2019

0.52.0-rc.0: Yoga Value Conversion Issue preventing build #17274

0.52.0-rc.0: Yoga Value Conversion Issue preventing build #17274

Comments

jaysig commented Dec 19, 2017 • edited Loading

Is this a bug report?

Have you read the Contributing Guidelines?

Environment

Steps to Reproduce

Expected Behavior

Actual Behavior

Reproducible Demo

shameemz commented Dec 20, 2017

jcady commented Dec 20, 2017

hpb0412 commented Jan 2, 2018

blackxored commented Jan 5, 2018

gabrielbull commented Jan 8, 2018 • edited Loading

gabrielbull commented Jan 8, 2018

turnrye commented Jan 8, 2018

priteshrnandgaonkar commented Jan 8, 2018

fungilation commented Jan 9, 2018 • edited Loading

LeVadim commented Jan 9, 2018

kontinuity commented Jan 9, 2018 • edited Loading

hanweixing commented Jan 9, 2018

bkitduy commented Jan 9, 2018 • edited Loading

hitbear518 commented Jan 9, 2018

raviatflexiloans commented Jan 9, 2018

allthetime commented Jan 9, 2018

vovkasm commented Jan 9, 2018

Dev process

Technical

vovkasm commented Jan 9, 2018

Jono20201 commented Jan 9, 2018

guysegal commented Jan 9, 2018 • edited Loading

vovkasm commented Jan 9, 2018

ma-pe commented Jan 9, 2018 • edited Loading

fungilation commented Jan 9, 2018 • edited Loading

gabrielbull commented Jan 9, 2018

fungilation commented Jan 9, 2018

dluksza commented Jan 9, 2018

msand commented Jan 18, 2018

antonsivogrivov commented Jan 19, 2018

msand commented Jan 19, 2018

OceanHorn commented Jan 24, 2018

ahmetilhann commented Jan 24, 2018

willbattel commented Jan 25, 2018

hugomosh commented Jan 25, 2018

grabbou commented Jan 25, 2018

maxkomarychev commented Jan 26, 2018

grabbou commented Jan 26, 2018

grabbou commented Jan 26, 2018

msand commented Jan 26, 2018

guysegal commented Jan 26, 2018

grabbou commented Jan 26, 2018

maxkomarychev commented Jan 26, 2018 • edited Loading

maxkomarychev commented Jan 26, 2018

grabbou commented Jan 26, 2018 via email

3degreeszw commented Feb 27, 2018

jayasimhaprasad commented Feb 28, 2018

hegelstad commented Mar 7, 2018

HemantRMali commented Mar 10, 2018 • edited Loading

sadeshp commented Mar 27, 2018 • edited Loading

jaysig commented Dec 19, 2017 •

edited

Loading

gabrielbull commented Jan 8, 2018 •

edited

Loading

fungilation commented Jan 9, 2018 •

edited

Loading

kontinuity commented Jan 9, 2018 •

edited

Loading

bkitduy commented Jan 9, 2018 •

edited

Loading

guysegal commented Jan 9, 2018 •

edited

Loading

ma-pe commented Jan 9, 2018 •

edited

Loading

fungilation commented Jan 9, 2018 •

edited

Loading

maxkomarychev commented Jan 26, 2018 •

edited

Loading

HemantRMali commented Mar 10, 2018 •

edited

Loading

sadeshp commented Mar 27, 2018 •

edited

Loading