Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport retro compatible commits for the Docusaurus v2.1 release #8033

Merged
merged 19 commits into from
Sep 2, 2022
Merged

chore: backport retro compatible commits for the Docusaurus v2.1 release #8033

merged 19 commits into from
Sep 2, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 1, 2022 •
edited
Loading

Motivation

chore: backport retro compatible commits for the Docusaurus v2.1 release

Docs are backported here #8036

whiteand and others added 19 commits September 1, 2022 13:35
@whiteand @slorber
fix: collapse siblings when first category is selected (#7786)
d521c74 
fix: not collapsing when first category is selected
@yzhe819 @slorber
fix(theme-classic): code block line number display with line wrapping (…
d0bc176 
…#7910)

* fix: line numbers display issue of code block

* test: add dogfooding test page

* chore: lint

* test: move to code-block-tests
@datlechin @slorber
chore(theme-translations): complete vi translations (#7928)
0f0570f 
docs: update Vietnamese translations
@Josh-Cena @slorber
docs: remove mention of beta (#7905)
fb710b6 
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
# Conflicts:
#	packages/docusaurus-plugin-ideal-image/package.json
@slorber
feat(theme-classic): use lang attribute in navbar locale dropdown ite…
dbc2c09 
…ms (#7942)
@Kosai106 @slorber
refactor(theme-classic): make tag text visually certered (#7876)
7c83ced
@slorber
feat(core): add new Webpack file-loader extensions: avif, mov, mkv, m…
745d0ea 
…pg, avi... (#7941)
@slorber
refactor(theme-classic): split AnnouncementBar, increase z-index, use…
7d25a02 
… shadow (#7940)
@slorber
feat(plugin-docs): docs sidebar item link: support "autoAddBaseUrl" a…
8447a29 
…ttribute (#7949)
@b-ovsepian @slorber
feat(theme): adds Ukrainian default theme translations (#7953)
6f1d066
@slorber
fix(sitemap): filter all routes with robots meta containing noindex (#…
c458f28 
…7964)
@slorber
feat(docs): allow to configure noIndex per doc version (#7963)
5edb652
@slorber
fix(core): allow overriding ssr/dev template meta tags (#7952)
0a2ab30
@slorber
fix(core): CLI command write-translations should extract translations…
62c2d1b 
… from @Docu… (#7996)
@YoniChechik @Josh-Cena @slorber
fix(theme): add aria-label to skip to content link region (#7982)
41aa801 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@adventure-yunfei @slorber
fix(core): preload should support encoded page links (#7977)
27e3b98 
Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
@slorber
feat(theme): ability to use <DocCardList> without items prop, on any …
6b65355 
…doc page (#8008)
@mdubus @slorber
fix(preset-classic): broken link in "unrecognized keys" error message (…
dc587bb 
…#8029)
@slorber
fix(create-docusaurus): tutorial and init template improvements (#8032)
b9e8721
@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Sep 1, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 1, 2022
@netlify
Copy link

netlify bot commented Sep 1, 2022

✅ [V2]

Name Link
🔨 Latest commit b9e8721
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63109b63d64a110008eb323f
😎 Deploy Preview https://deploy-preview-8033--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Size Change: +1.91 kB (0%)

Total Size: 807 kB

Filename Size Change
website/build/assets/css/styles.********.css 106 kB +57 B (0%)
website/build/assets/js/main.********.js 609 kB +1.71 kB (0%)
website/build/index.html 39 kB +144 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.8 kB

compressed-size-action

Josh-Cena
Josh-Cena approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance—

Do you have ideas about how doc versioning should work, though?

@slorber
Copy link
Collaborator Author

slorber commented Sep 1, 2022

Do you have ideas about how doc versioning should work, though?

Yes, we backport manually the docs on main, like if docs were on another repo (like RN website). That's also why I'd rather not backport too much docs 😅 it's manual. Doing it now

@slorber slorber mentioned this pull request Sep 1, 2022
Merged
@slorber slorber changed the title chore: backport retrocompatible commits for the Docusaurus v2.1 release chore: backport retro compatible commits for the Docusaurus v2.1 release Sep 2, 2022
@slorber slorber merged commit 26d2b9a into docusaurus-v2 Sep 2, 2022
@slorber slorber deleted the slorber/docusaurus-v2.1-backport branch September 2, 2022 10:20
@slorber slorber mentioned this pull request Sep 2, 2022
Merged
@slorber slorber added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. and removed pr: maintenance This PR does not produce any behavior differences to end users when upgrading. pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. labels Sep 2, 2022
@slorber slorber mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.