Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-classic): code block line number display with line wrapping #7910

Merged
merged 4 commits into from
Aug 7, 2022
Merged

fix(theme-classic): code block line number display with line wrapping #7910

merged 4 commits into from
Aug 7, 2022

Conversation

yzhe819
Copy link
Contributor

@yzhe819 yzhe819 commented Aug 7, 2022 •
edited by Josh-Cena
Loading

Pre-flight checklist

Motivation

Fixes #7907

Test Plan

Add the dogfooding test page

Test links

dev link: https://3000-yzhe819-docusaurus-af96kcuq0jz.ws-us59.gitpod.io/tests/docs/code-wrap-test

Deploy preview: https://deploy-preview-7910--docusaurus-2.netlify.app/tests/pages/code-block-tests#code-block-wrapping-tests

Related issues/PRs

#7907

Related screenshot

screenshot of issue

图片

@facebook-github-bot
Copy link
Contributor

Hi @yzhe819!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Aug 7, 2022
@netlify
Copy link

netlify bot commented Aug 7, 2022 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e08a77b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62efd16a76c94d000a9309b8
😎 Deploy Preview https://deploy-preview-7910--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Aug 7, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 77 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 72 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 7, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Josh-Cena
Josh-Cena approved these changes Aug 7, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Thanks a lot! Congratulations on your first contribution here!

@Josh-Cena Josh-Cena changed the title fix(theme-classic): code block line number display issue fix(theme-classic): properly display code block line numbers with line wrapping Aug 7, 2022
@Josh-Cena Josh-Cena changed the title fix(theme-classic): properly display code block line numbers with line wrapping fix(theme-classic): code block line number display with line wrapping Aug 7, 2022
@Josh-Cena Josh-Cena added the to backport This PR is planned to be backported to a stable version of Docusaurus label Aug 7, 2022
@Josh-Cena Josh-Cena merged commit d938ff7 into facebook:main Aug 7, 2022
slorber pushed a commit that referenced this pull request Sep 1, 2022
@yzhe819 @slorber
fix(theme-classic): code block line number display with line wrapping (…
d0bc176 
…#7910)

* fix: line numbers display issue of code block

* test: add dogfooding test page

* chore: lint

* test: move to code-block-tests
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 28, 2022
@slorber slorber mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent code block line numbers when word wrap is on
4 participants
@yzhe819 @facebook-github-bot @Josh-Cena @slorber