add vary origin header for specifc origins #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the server specifies an origin host rather than "*", then it must also include Origin in the Vary response header to indicate to clients that server responses will differ based on the value of the Origin request header. https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Origin
troygoode
added a commit
that referenced
this pull request
Oct 23, 2014
add vary origin header for specifc origins
|
nice catch |
|
thanks @soarez. this is now on npm as |
|
This will remove any previously-set |
troygoode
added a commit
that referenced
this pull request
Nov 7, 2014
|
great suggestion @dougwilson (and thanks for writing the module :-)) - I've published this as |
|
yay! I'm glad you added the |
troygoode
added a commit
that referenced
this pull request
Nov 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server specifies an origin host rather than "*", then it must
also include Origin in the Vary response header to indicate to clients
that server responses will differ based on the value of the Origin
request header.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Origin