Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library no longer supports non-express applications #33

Closed
troygoode opened this issue Nov 10, 2014 · 2 comments
Closed

library no longer supports non-express applications #33

troygoode opened this issue Nov 10, 2014 · 2 comments
Assignees
@troygoode
Labels
bug

Comments

@troygoode
Copy link
Member

165f35e#commitcomment-8496165
@troygoode troygoode added the bug label Nov 10, 2014
@troygoode troygoode self-assigned this Nov 10, 2014
troygoode added a commit that referenced this issue Nov 10, 2014
@troygoode
#33: fix bug that dropped support for non-Express apps in #30
fee800f
troygoode referenced this issue Nov 10, 2014
@troygoode
#30: use the vary module
165f35e
@cgiffard
Copy link

Thanks so much for getting this fixed so fast! I can verify it now passes our test suite. :)

We defer loading express for performance reasons, and this is one of the few middleware modules/functions that runs before express, so having it capable of running on bare-node-HTTP is really useful. Also it's super fast! Thanks for that. :)

@troygoode
Copy link
Member Author

That is great to hear @cgiffard! I never intended the library to work without express, but now that I know that it does I'll endeavor to keep that functionality intact. Thanks for pointing the issue out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@troygoode troygoode

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@troygoode @cgiffard