Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Improved service account display in submission summary #674

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

barthap
Copy link
Contributor

@barthap barthap commented Oct 7, 2021

Checklist

Didn't add changelog entry since the original change in #664 hasn't been published yet

Why

I think that it would be more consistent with how we display Build in submission summary - a "nested group" is made for related fields:

Before

Screenshot 2021-10-07 at 12 52 25

After

Screenshot 2021-10-07 at 12 58 00

How

Copied summary formatting from Build section

Test Plan

Ran it and took screenshots visible above

@barthap barthap requested review from dsokal and quinlanj October 7, 2021 10:59
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #674 (14925ec) into main (12ded8c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   49.63%   49.66%   +0.03%     
==========================================
  Files         313      313              
  Lines       10778    10784       +6     
  Branches     2006     2006              
==========================================
+ Hits         5349     5355       +6     
  Misses       5423     5423              
  Partials        6        6              
Impacted Files Coverage Δ
...ges/eas-cli/src/submit/android/AndroidSubmitter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ded8c...14925ec. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Size Change: +255 B (0%)

Total Size: 22.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 22.5 MB +255 B (0%)

compressed-size-action

}[];

return (
'\n' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use template string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried that, but IMO the code becomes less readable:

  return `\n${formatFields(filteredFields, {
    labelFormat: label => `    ${chalk.dim(label)}:`,
  })}`;

@barthap barthap merged commit dc4e36e into main Oct 8, 2021
@barthap barthap deleted the @barthap/submit-summary-service-account branch October 8, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants