Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] integrated credentials service with android submissions #664

Merged
merged 7 commits into from
Oct 6, 2021

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Oct 4, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

This PR integrates the credentials service into the Android submission workflow. Notable changes:

  • If the user passes in the path argument when they run submissions, we use that and fall back to a prompt if there the path they passed was invalid. No credentials are saved on www in this case.
  • If there is no path argument when submissions is run, we use the credentials service.

Test Plan

  • manually test important cases
  • new tests pass

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

Size Change: +40 B (0%)

Total Size: 22.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 22.5 MB +40 B (0%)

compressed-size-action

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@barthap barthap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! tested it locally, glad to have the autodetection working 🎉

@quinlanj quinlanj changed the title [ PLS REVIEW :) ][eas-cli] integrated credentials service with android submissions [eas-cli] integrated credentials service with android submissions Oct 4, 2021
@quinlanj quinlanj requested review from barthap and dsokal October 5, 2021 01:11
@quinlanj quinlanj marked this pull request as ready for review October 5, 2021 01:11
@quinlanj quinlanj force-pushed the @quin/submissionCredsAndroid branch from c9d381b to a49e2dd Compare October 6, 2021 18:48
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Size Change: +40 B (0%)

Total Size: 22.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 22.5 MB +40 B (0%)

compressed-size-action

@quinlanj quinlanj merged commit 12ded8c into main Oct 6, 2021
@quinlanj quinlanj deleted the @quin/submissionCredsAndroid branch October 6, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants