-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] integrated credentials service with android submissions #664
Conversation
Size Change: +40 B (0%) Total Size: 22.5 MB
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! tested it locally, glad to have the autodetection working 🎉
c9d381b
to
a49e2dd
Compare
Size Change: +40 B (0%) Total Size: 22.5 MB
|
Checklist
[EAS BUILD API]
if it's a part of a breaking change to EAS Build API (only possible when updating@expo/eas-build-job
package).Why
This PR integrates the credentials service into the Android submission workflow. Notable changes:
Test Plan