Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-755] add --non-interactive flag for eas submit #600

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Sep 8, 2021

Checklist

  • I've added an entry to CHANGELOG.md if necessary.
  • I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why

eas submit should fail with an error if it has been run with the --non-interactive flag but a user interaction is required (prompt).

How

  • I made eas sumit fail if the user didn't provide all necessary data with eas.json and env vars, and ran the submit with --non-interactive.
  • I refactored resolving iOS asc app identifier and apple id.

Test Plan

  • Added basic unit tests.
  • Tested manually.

@dsokal dsokal changed the base branch from main to @dsokal/submit-platform-all September 8, 2021 15:09
@dsokal dsokal force-pushed the @dsokal/non-interactive-submits branch from c67e494 to 6a49cd7 Compare September 8, 2021 15:13
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Size Change: -599 B (0%)

Total Size: 43.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 43.9 MB -599 B (0%)

compressed-size-action

@dsokal dsokal force-pushed the @dsokal/non-interactive-submits branch from 6a49cd7 to a2d9aea Compare September 8, 2021 15:14
Base automatically changed from @dsokal/submit-platform-all to main September 9, 2021 07:50
@dsokal dsokal force-pushed the @dsokal/non-interactive-submits branch from a2d9aea to cd957ae Compare September 9, 2021 09:50
@dsokal dsokal marked this pull request as ready for review September 9, 2021 10:19
@dsokal dsokal requested review from barthap and wkozyra95 September 9, 2021 10:19
@dsokal dsokal merged commit acf7e55 into main Sep 9, 2021
@dsokal dsokal deleted the @dsokal/non-interactive-submits branch September 9, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants