-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Add non-interactive flag to eas update command #1066
Conversation
ENG-4590 Add --non-interactive flag to `eas update`
Currently, we might ask a question about if you want to install expo-updates when running EAS CLI, which can break CI. When CI breaks, there's no indication of what we tried to get input for. Just an error. We need to throw the log before we throw the error, or we need to add a default choice with a |
/changelog-entry new-feature Add non-interactive flag to eas update command |
Size Change: +649 B (0%) Total Size: 25.2 MB
|
Codecov Report
@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
- Coverage 50.29% 50.26% -0.03%
==========================================
Files 348 348
Lines 12707 12708 +1
Branches 2439 2443 +4
==========================================
- Hits 6390 6386 -4
- Misses 6306 6311 +5
Partials 11 11
Continue to review full report at Codecov.
|
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]
and CHANGELOG.md will be updated automatically.Why
Currently, we might ask a question about if you want to install expo-updates when running EAS CLI, which can break CI. When CI breaks, there's no indication of what we tried to get input for. Just an error.
We need to throw the log before we throw the error, or we need to add a default choice with a --non-interactive flag.
This PR adds the non-interactive flag to be in alignment with the other commands.
Closes ENG-4590.
How
Used #600 as inspiration. Added flag, test manually (there's no tests for this command).
Test Plan