Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpose : Modified example.py to avoid exception #459

Merged
merged 6 commits into from
Apr 8, 2017
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,12 @@
"topics": [
]
},
{
"slug": "transpose",
"difficulty": 1,
"topics": [
]
},
{
"slug": "poker",
"difficulty": 1,
Expand Down
9 changes: 9 additions & 0 deletions exercises/transpose/example.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@

def transpose(input_lines):
lines = input_lines.split("\n")
zipped = map(list, [line.ljust(len(max(lines, key=len))) for line in lines])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to move to the default PEP8 line limit of 80 #434. So this line needs to be fixed.

return "\n".join("".join(line) for line in zip(*zipped)).strip()


if __name__ == '__main__':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this the last time, but we don't need that here and the call would even throw an exception.

transpose()
3 changes: 3 additions & 0 deletions exercises/transpose/transpose.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove this blank line.

def transpose():
pass
275 changes: 275 additions & 0 deletions exercises/transpose/transpose_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,275 @@
import unittest
from transpose import transpose


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the test data version (# test cases adapted from x-common//canonical-data.json @ version: 1.0.0) here, like here: https://github.com/exercism/xpython/blob/master/exercises/hello-world/hello_world_test.py#L6

class TransposeTests(unittest.TestCase):
def test_empty_string(self):
input_line = ""
expected = ""
self.assertEqual(
expected,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters in all assertEqual() calls need to be switched. Details and the background can be found here: #440

transpose(input_line)
)

def test_two_characters_in_a_row(self):
input_line = ["A1"]
expected = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more readable if this is in one line expected = ["A", "1"]
... or when the input is that small maybe even without the variables.

self.assertEqual("\n".join(["A", "1"]), transpose("A1"))

"A",
"1"
]
self.assertEqual(
"\n".join(expected),
transpose("\n".join(input_line))
)

def test_two_characters_in_a_column(self):
input_line = [
"A",
"1"
]
expected = [
"A1"
]

self.assertEqual(
"\n".join(expected),
transpose("\n".join(input_line))
)

def test_simple(self):
input_line = [
"ABC",
"123"
]
expected = [
"A1",
"B2",
"C3"
]

self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_single_line(self):
input_line = ["Single line."]
expected = [
"S",
"i",
"n",
"g",
"l",
"e",
" ",
"l",
"i",
"n",
"e",
"."
]
self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_first_line_longer_than_second_line(self):
input_line = [
"The fourth line.",
"The fifth line."
]
expected = [
"TT",
"hh",
"ee",
" ",
"ff",
"oi",
"uf",
"rt",
"th",
"h ",
" l",
"li",
"in",
"ne",
"e.",
"."
]
self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_second_line_longer_than_first_line(self):
input_line = [
"The first line.",
"The second line."
]
expected = [
"TT",
"hh",
"ee",
" ",
"fs",
"ie",
"rc",
"so",
"tn",
" d",
"l ",
"il",
"ni",
"en",
".e",
" ."
]
self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_square(self):
input_line = [
"HEART",
"EMBER",
"ABUSE",
"RESIN",
"TREND"
]
expected = [
"HEART",
"EMBER",
"ABUSE",
"RESIN",
"TREND"
]
self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_rectangle(self):
input_line = [
"FRACTURE",
"OUTLINED",
"BLOOMING",
"SEPTETTE"
]
expected = [
"FOBS",
"RULE",
"ATOP",
"CLOT",
"TIME",
"UNIT",
"RENT",
"EDGE"
]
self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_triangle(self):
input_line = [
"T",
"EE",
"AAA",
"SSSS",
"EEEEE",
"RRRRRR"
]
expected = [
"TEASER",
" EASER",
" ASER",
" SER",
" ER",
" R"
]
self.assertEqual(
'\n'.join(expected),
transpose('\n'.join(input_line))
)

def test_many_lines(self):
input_line = [
"Chor. Two households, both alike in dignity,",
"In fair Verona, where we lay our scene,",
"From ancient grudge break to new mutiny,",
"Where civil blood makes civil hands unclean.",
"From forth the fatal loins of these two foes",
"A pair of star-cross'd lovers take their life;",
"Whose misadventur'd piteous overthrows",
"Doth with their death bury their parents' strife.",
"The fearful passage of their death-mark'd love,",
"And the continuance of their parents' rage,",
"Which, but their children's end, naught could remove,",
"Is now the two hours' traffic of our stage;",
"The which if you with patient ears attend,",
"What here shall miss, our toil shall strive to mend."
]
expected = [
"CIFWFAWDTAWITW",
"hnrhr hohnhshh",
"o oeopotedi ea",
"rfmrmash cn t",
".a e ie fthow ",
" ia fr weh,whh",
"Trnco miae ie",
"w ciroitr btcr",
"oVivtfshfcuhhe",
" eeih a uote ",
"hrnl sdtln is",
"oot ttvh tttfh",
"un bhaeepihw a",
"saglernianeoyl",
"e,ro -trsui ol",
"h uofcu sarhu ",
"owddarrdan o m",
"lhg to'egccuwi",
"deemasdaeehris",
"sr als t ists",
",ebk 'phool'h,",
" reldi ffd ",
"bweso tb rtpo",
"oea ileutterau",
"t kcnoorhhnatr",
"hl isvuyee'fi ",
" atv es iisfet",
"ayoior trr ino",
"l lfsoh ecti",
"ion vedpn l",
"kuehtteieadoe ",
"erwaharrar,fas",
" nekt te rh",
"ismdsehphnnosa",
"ncuse ra-tau l",
" et tormsural",
"dniuthwea'g t ",
"iennwesnr hsts",
"g,ycoi tkrttet",
"n ,l r s'a anr",
"i ef 'dgcgdi",
"t aol eoe,v",
"y nei sl,u; e",
", .sf to l ",
" e rv d t",
" ; ie o",
" f, r ",
" e e m",
" . m e",
" o n",
" v d",
" e .",
" ,"
]
self.assertEqual(
'\n'.join(expected),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the times you use double quotes ("\n".joi..). This should be uniform. There are more lines than this.

transpose('\n'.join(input_line))
)


if __name__ == '__main__':
unittest.main()