transpose : Modified example.py to avoid exception #459

nithin-vijayan · 2017-03-30T08:22:03Z

Added example.py and exercise test files. Updated config.json. Please review

behrtam

All in all this looks great, there are just some smaller issues ...

behrtam · 2017-03-30T13:56:47Z

exercises/transpose/transpose.py

@@ -0,0 +1,3 @@
+


Could you remove this blank line.

behrtam · 2017-03-30T13:56:52Z

exercises/transpose/example.py

+
+def transpose(input_lines):
+    lines = input_lines.split("\n")
+    zipped = map(list, [line.ljust(len(max(lines, key=len))) for line in lines])


We want to move to the default PEP8 line limit of 80 #434. So this line needs to be fixed.

behrtam · 2017-03-30T14:04:58Z

exercises/transpose/transpose_test.py

+        input_line = ""
+        expected = ""
+        self.assertEqual(
+            expected,


The parameters in all assertEqual() calls need to be switched. Details and the background can be found here: #440

behrtam · 2017-03-30T14:05:01Z

exercises/transpose/transpose_test.py

+import unittest
+from transpose import transpose
+
+


Could you add the test data version (# test cases adapted from x-common//canonical-data.json @ version: 1.0.0) here, like here: https://github.com/exercism/xpython/blob/master/exercises/hello-world/hello_world_test.py#L6

behrtam · 2017-03-30T14:05:09Z

exercises/transpose/transpose_test.py

+            "          ,"
+        ]
+        self.assertEqual(
+            '\n'.join(expected),


Most of the times you use double quotes ("\n".joi..). This should be uniform. There are more lines than this.

behrtam · 2017-03-30T14:08:17Z

exercises/transpose/transpose_test.py

+
+    def test_two_characters_in_a_row(self):
+        input_line = ["A1"]
+        expected = [


I think it would be more readable if this is in one line expected = ["A", "1"]
... or when the input is that small maybe even without the variables.

self.assertEqual("\n".join(["A", "1"]), transpose("A1"))

nithin-vijayan · 2017-03-30T15:54:12Z

sure, will rectify those issues soon. thanks

nithin-vijayan · 2017-03-31T03:56:31Z

I have modified the code to follow design guidelines. Please review and report back in case of issues.

behrtam · 2017-03-31T06:45:29Z

exercises/transpose/example.py

+    return "\n".join("".join(line) for line in zip(*zipped)).strip()
+
+
+if __name__ == '__main__':


Sorry I missed this the last time, but we don't need that here and the call would even throw an exception.

nithin-vijayan · 2017-04-01T06:12:11Z

Done. Sorry about that. Making a lot of mistakes as it is my first contribution 😄

* Create common working area * Extract Concepts from v2 exercise: reverse-string (exercism#657) * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity (exercism#503) * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree (exercism#501) * Add initial list (exercism#463) First pass concepts for `allergies` to address exercism#460 * Initial list of concepts (exercism#462) First pass list of concepts to address exercism#459 * Add Concepts for v2 exercise: phone-number (exercism#420) * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming (exercism#418) * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. (exercism#395) * Extract Concepts from v2 exercise: markdown (exercism#540) * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix (exercism#416) * `matrix` exercise concepts (issue exercism#386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match exercism#290 Formatting Edited concepts to better match the formatting of issue exercism#290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription (exercism#520) * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator (exercism#538) * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions (exercism#665) * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 (exercism#705) * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification (exercism#793) * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

* Create common working area * Extract Concepts from v2 exercise: reverse-string * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree * Add initial list First pass concepts for `allergies` to address exercism#460 * Initial list of concepts First pass list of concepts to address exercism#459 * Add Concepts for v2 exercise: phone-number * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. * Extract Concepts from v2 exercise: markdown * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix * `matrix` exercise concepts (issue exercism#386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match exercism#290 Formatting Edited concepts to better match the formatting of issue exercism#290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

* Create common working area * Extract Concepts from v2 exercise: reverse-string * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree * Add initial list First pass concepts for `allergies` to address #460 * Initial list of concepts First pass list of concepts to address #459 * Add Concepts for v2 exercise: phone-number * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. * Extract Concepts from v2 exercise: markdown * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix * `matrix` exercise concepts (issue #386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match #290 Formatting Edited concepts to better match the formatting of issue #290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

nk and others added 3 commits March 26, 2017 18:55

dibs: I will implement exercise Transpose

cd67aef

dibs: I will implement exercise Transpose

e9156b1

transpose : Added test files and example

308e5f2

nithin-vijayan changed the title ~~Exercise/transpose~~ transpose : Added test cases and sample solution Mar 30, 2017

updated config.json

5c1b4e1

behrtam mentioned this pull request Mar 30, 2017

Add exercise transpose #456

Closed

behrtam reviewed Mar 30, 2017

View reviewed changes

transpose : Modified code to follow guidlines

0af722e

nithin-vijayan changed the title ~~transpose : Added test cases and sample solution~~ transpose : Modified code to follow PEP 8 Guidelines Mar 31, 2017

behrtam reviewed Mar 31, 2017

View reviewed changes

transpose : Modified example.py to avoid exception

fb23e00

nithin-vijayan changed the title ~~transpose : Modified code to follow PEP 8 Guidelines~~ transpose : Modified example.py to avoid exception Apr 1, 2017

behrtam force-pushed the master branch from 7a84127 to bd1fed9 Compare April 2, 2017 15:10

behrtam merged commit 6ad913d into exercism:master Apr 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

transpose : Modified example.py to avoid exception #459

transpose : Modified example.py to avoid exception #459

nithin-vijayan commented Mar 30, 2017 •

edited

Loading

behrtam left a comment

behrtam Mar 30, 2017

behrtam Mar 30, 2017

behrtam Mar 30, 2017

behrtam Mar 30, 2017

behrtam Mar 30, 2017

behrtam Mar 30, 2017

nithin-vijayan commented Mar 30, 2017

nithin-vijayan commented Mar 31, 2017

behrtam Mar 31, 2017

nithin-vijayan commented Apr 1, 2017

		return "\n".join("".join(line) for line in zip(*zipped)).strip()


		if __name__ == '__main__':

transpose : Modified example.py to avoid exception #459

transpose : Modified example.py to avoid exception #459

Conversation

nithin-vijayan commented Mar 30, 2017 • edited Loading

behrtam left a comment

Choose a reason for hiding this comment

behrtam Mar 30, 2017

Choose a reason for hiding this comment

behrtam Mar 30, 2017

Choose a reason for hiding this comment

behrtam Mar 30, 2017

Choose a reason for hiding this comment

behrtam Mar 30, 2017

Choose a reason for hiding this comment

behrtam Mar 30, 2017

Choose a reason for hiding this comment

behrtam Mar 30, 2017

Choose a reason for hiding this comment

nithin-vijayan commented Mar 30, 2017

nithin-vijayan commented Mar 31, 2017

behrtam Mar 31, 2017

Choose a reason for hiding this comment

nithin-vijayan commented Apr 1, 2017

nithin-vijayan commented Mar 30, 2017 •

edited

Loading