Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contributing translation of js's track 'forth' excersize. #398

Merged
merged 7 commits into from
Oct 8, 2022
Merged

contributing translation of js's track 'forth' excersize. #398

merged 7 commits into from
Oct 8, 2022

Conversation

AlexeyBukin
Copy link
Contributor

Hope it will be first 'hard' task.

@AlexeyBukin
Copy link
Contributor Author

@kotp @houhoulis @fwip any thoughts?

@AlexeyBukin @kotp
Update exercises/practice/forth/.docs/instructions.md
d4cbd57 
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
@AlexeyBukin AlexeyBukin requested a review from kotp September 29, 2022 21:02
@kotp
Copy link
Member

kotp commented Sep 29, 2022

I do not have "approvers" access, though I can review. If you can request review of the @exercism/dart (mentioned here, so not likely necessary), it will go better for this PR.

Stargator
Stargator requested changes Oct 1, 2022
View reviewed changes
Copy link
Contributor

@Stargator Stargator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I started a review, but never submitted it.

exercises/practice/forth/.meta/lib/example.dart Outdated Show resolved Hide resolved
@Stargator
Copy link
Contributor

Stargator commented Oct 1, 2022 •
edited
Loading

@AlexeyBukin I approved to run the checks. Please add the forth as a slug for practice exercises and fix the broken link in ./CODE_OF_CONDUCT.md as noted in the linkChecker check.

I know you didn't change the link, but this is our way of making sure we catch when links break.

Thank you for your contribution.

@AlexeyBukin
Copy link
Contributor Author

AlexeyBukin commented Oct 7, 2022 •
edited
Loading

@Stargator

fix the broken link in ./CODE_OF_CONDUCT.md as noted in the linkChecker check.

I don't see any failed checks and have no idea how to run any, sorry.

@AlexeyBukin AlexeyBukin requested review from Stargator and removed request for kotp October 7, 2022 18:08
@Stargator
Copy link
Contributor

@AlexeyBukin, you're not seeing anything here?

@Stargator
Copy link
Contributor

@AlexeyBukin I'm going to update our link checker to a newer version and see if that fixes the issue.

@Stargator Stargator merged commit c011425 into exercism:main Oct 8, 2022
@Stargator
Copy link
Contributor

Thanks, @AlexeyBukin it all looks good to me. I appreciate.

@devkabiir devkabiir mentioned this pull request Oct 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotp kotp kotp left review comments

@Stargator Stargator Stargator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexeyBukin @kotp @Stargator