-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Re-enable link checker #420
Comments
We could try enabling it in a PR to see what breaks. |
The link checker or Links workflow was disabled due to a bug that caused it not to handle mailto links properly. So it would fail every time if a file that contained a mailto was modified. I checked the repo for the underlying library and no new releases since 0.10.1, which is what we currently use. |
Got it! Thanks for checking. |
We're looking to add a link checker to problem-specifications as well. This is the PR: exercism/problem-specifications#2145 Once that one is resolved we'll likely have a way forward in this repository as well. |
lynchee is pretty useful. But I'm not tied to it. Feel free to do a manual run of our Link workflow to ensure it still fails at mailto link, which lynchee should support. |
@kytrinyx Since the lychee action was just updated, I re-ran the workflow and it's still failing for mailto. |
This is the related issue at lychee |
Thank you for checking, @Stargator. |
Fix is here: lycheeverse/lychee#809. |
New version of lychee-action with the fix is out. |
Thanks, @mre! I re-enabled the workflow, it's passing. So I'm leaving in en-enabled. |
As part of #398, the link checker workflow was disabled for exercises.
@Stargator may have more insights as to why that change was made & whether it should be fixed or kept as is.
This issue tracks that change.
The text was updated successfully, but these errors were encountered: