Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 MAINT: Pin ipykernel to ~v5.5 #347

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

choldgraf
Copy link
Member

closes #346

@chrisjsewell chrisjsewell self-requested a review August 6, 2021 14:34
chrisjsewell
chrisjsewell previously approved these changes Aug 6, 2021
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! (Providing the tests now pass)

if you could also open an issue for eventually updating the tests to ipykernel v6 (although I think this has dropped support for python 3.6, so we would also need to drop that)

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #347 (951013a) into master (e39132e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          12       12           
  Lines        1337     1337           
=======================================
  Hits         1169     1169           
  Misses        168      168           
Flag Coverage Δ
pytests 87.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467d5fa...951013a. Read the comment docs.

setup.cfg Outdated
@@ -95,6 +95,7 @@ testing =
pytest-cov~=2.8
pytest-regressions
sympy
ipykernel~=5.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick: can we move this up to be in alphabetical order 😬

@choldgraf
Copy link
Member Author

thanks for the review - I opened up #348 and moved the dep

@choldgraf choldgraf force-pushed the ipykd branch 2 times, most recently from 830daef to 356b2e9 Compare August 6, 2021 18:12
@choldgraf
Copy link
Member Author

ok gonna merge this one since we're fixing a failing test on master...

@choldgraf choldgraf merged commit 27e9aee into executablebooks:master Aug 6, 2021
@choldgraf choldgraf deleted the ipykd branch August 6, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing due to regression in ipynb error messages
2 participants