Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing due to regression in ipynb error messages #346

Closed
choldgraf opened this issue Aug 6, 2021 · 0 comments · Fixed by #347
Closed

Tests failing due to regression in ipynb error messages #346

choldgraf opened this issue Aug 6, 2021 · 0 comments · Fixed by #347
Labels
bug Something isn't working

Comments

@choldgraf
Copy link
Member

choldgraf commented Aug 6, 2021

Describe the problem

The tests are currently failing because the output syntax for errors seem to have changed:

https://github.com/executablebooks/MyST-NB/runs/3210843582#step:5:233

I tried debugging this locally but it seems like the ipykernel_NNN part of the error message changes each time the test is run, so always fails.

@chrisjsewell suggested the following may be the issue:

The ipykernel now being installed is ipykernel-6.0.3, whereas previously it was ipykernel-5.5.5, so the easiest thing would be to just add ipykernel~=5.5 to the testing extra

@choldgraf choldgraf added the bug Something isn't working label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant