Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Target Energy API & UI for Vehicles Without SoC #4639

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

andig
Copy link
Member

@andig andig commented Sep 29, 2022

Fix #2632: the target energy api will only be offered if vehicle does not support SoC

  • add charged energy amount api
  • mark/identify non-soc vehicles
  • add ui

Out of scope:

  • add range (SoC diff is shown when capacity is given)
  • target charging (won't work!)

UI Changes

kwh-based-charging

  • Vehicle with unknown SoC (offline vehicles, guest vehicles) get the ability to specify a kWh based limit
  • Limit can be changed in 5 kWh increments (default), 1 kWh for vehicle capacity < 25 kWh, 2 kWh for vehicle capacity < 50 kWh)
  • Progressbar shows the progress towards the energy target
  • If vehicle capacity is known an estimated SoC diff is shown as extra info (e.g. +22%)
  • When kWh based charging is active the "charged/geladen" information is shown at the bottom left and replaces the SoC to create symmetry. "Charged kWh / Target kWh" and "Current SoC / Target SoC".

More Screenshots

guest vehicle
guest

soc diffs
soc diffs

selection
selection

english
english

@andig andig added the enhancement New feature or request label Sep 29, 2022
@andig andig marked this pull request as draft September 29, 2022 15:46
@naltatis naltatis changed the title Add target energy api Add Target Energy API & UI for Vehicles Without SoC Sep 30, 2022
@naltatis naltatis marked this pull request as ready for review September 30, 2022 15:56
@andig
Copy link
Member Author

andig commented Sep 30, 2022

Supergeil!

@premultiply
Copy link
Member

Das kann man so sagen! 👌

@naltatis naltatis merged commit 26f1495 into master Oct 4, 2022
@naltatis naltatis deleted the feature/target-energy branch October 4, 2022 18:08
@Hofyyy
Copy link
Contributor

Hofyyy commented Oct 4, 2022

Das nenne ich auch mal NICE

@andig andig added the ux User experience/ interface label Oct 5, 2022
@Headroom42
Copy link

Weltklasse! Vielen Dank dafür :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience/ interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mindestladung anhand Reichweite oder Energiemenge definieren
5 participants