-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for HTTPS testing #50
Conversation
…o feature/https_support
I think you can use |
@vidartf thanks for the tip with Let me know what you think! |
NamedTemporaryFiles cannot be reopen while still open on Windows. By closing it first, we can use it. So we have to manage deletion manually.
Note: I added a commit for making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending your review of my commit! The only possible improvement I can see would be to give a warning if a user requests a mismatched secure/non-secure server/client/port tuple. Could be an easy typo that would be hard to catch, but I'm not sure if it is worth the effort though, so I will leave that as a possible follow-up PR (ping if you want it).
I'm fine with this.
I would skip this for now and wait how users are picking up the new feature. If this becomes a common mistake I think such a warning should be implemented. |
This adds support for testing with HTTPS.
Based on the work of @judeaugustinej in PR #22 to fix #21.
It adds fixtures
https_port
,https_server
,https_client
andsecure_base_url
.Even though it works I'd like things to be easier to use in regard of
base_url
, because this introduces another fixturesecure_base_url
. I'd like to have only thebase_url
fixture available but am currently not sure if or how this could be implemented.Feedback in this regard is more than welcome!
Options for SSL have to be given through an fixture
ssl_options
in a way like currentlyapp
is used.