Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for https testing #21

Closed
judeaugustinej opened this issue Apr 13, 2017 · 2 comments · Fixed by #50
Closed

Support for https testing #21

judeaugustinej opened this issue Apr 13, 2017 · 2 comments · Fixed by #50

Comments

@judeaugustinej
Copy link
Contributor

In tornado Testing for https is provide by the class AsyncHTTPSTestCase

http://www.tornadoweb.org/en/stable/_modules/tornado/testing.html#AsyncHTTPSTestCase

does pytest-tornado provide anything like that

@okin
Copy link
Contributor

okin commented Mar 31, 2019

I don't think there is currently support for this in pytest-tornado.

From my understanding of the comment in the tornado docs the cert used for HTTPS testing has to be generated manually. Therefore I think it would make sense to let the user provide this in a way we currently handle the app fixture.

Do we want users to automatically have tests run against HTTP and HTTPS once a cert is provided? If so how would we handle cases where only one of these should be tested?
Or would users have to explicitely define if they want HTTP or HTTPS (i.e. by passing http_client or something like https_client as test function fixture).

@okin
Copy link
Contributor

okin commented Mar 31, 2019

Ah, there is already PR #22. Didn't see that.

The route there is that users define if they want their clients to be http or https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants