Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LJ-343 Allow search by default in all Selects #5738

Merged
merged 4 commits into from
Feb 6, 2025
Merged

LJ-343 Allow search by default in all Selects #5738

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f45a23a
LJ-343 Allow search by default in all Selects
lucanovera Feb 5, 2025
c893f1e
Update changelog
lucanovera Feb 5, 2025
36d65ea
remove props no longer needed
lucanovera Feb 5, 2025
b95a563
Merge branch 'main' of github.com:ethyca/fides into LJ-343-Allow-sear…
lucanovera Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
- Added frequency field to DataHubSchema integration config [#5716](https://github.com/ethyca/fides/pull/5716)
- Added glossary_node field to DataHubSchema integration config [#5734](https://github.com/ethyca/fides/pull/5734)
- Added initial support for upcoming "headless" CMP experience type [#5731](https://github.com/ethyca/fides/pull/5731)
- All Select dropdowns will now allow searching to narrow down the options by default [#5738](https://github.com/ethyca/fides/pull/5738)


### Fixed
- Fixed `fides annotate dataset` command enters incorrect value on the `direction` field. [#5727](https://github.com/ethyca/fides/pull/5727)
Expand Down
2 changes: 2 additions & 0 deletions clients/fidesui/src/hoc/CustomSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const withCustomProps = (WrappedComponent: typeof Select) => {
placeholder = "Select...",
optionRender = optionDescriptionRender,
className = "w-full",
showSearch = true,
suffixIcon,
menuItemSelectedIcon = <Checkmark />,
...props
Expand All @@ -44,6 +45,7 @@ const withCustomProps = (WrappedComponent: typeof Select) => {
placeholder,
optionRender,
className,
showSearch,
suffixIcon: props.loading ? undefined : suffixIcon || <ChevronDown />,
menuItemSelectedIcon,
"data-testid": `select${props.id ? `-${props.id}` : ""}`,
Expand Down