Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LJ-343 Allow search by default in all Selects #5738

Merged
merged 4 commits into from
Feb 6, 2025
Merged

LJ-343 Allow search by default in all Selects #5738

merged 4 commits into from
Feb 6, 2025

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Feb 5, 2025 •
edited
Loading

Description Of Changes

Change default options for Select component to allow search by default.

Code Changes

  • Set default props to showSearch = true
  • Remove showSearch from components since it's no longer needed

Steps to Confirm

  1. Login to admin ui
  2. Go to any system and add a new Data Use
  3. Check that all Selects within this modal allow typing to filter the dropdown options

Note: This change applies to all Selects in the product, but specifically this modal has a few Selects that didn't have a showModal prop, so it's a good test for the new default behavior.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:54pm

@cypress Cypress
Copy link

cypress bot commented Feb 5, 2025 •
edited
Loading

fides    Run #12201

Run Properties:  status check passed Passed #12201  •  git commit 6cc4e8531d ℹ️: Merge b95a563555f3f1210fd680d899beff5473cc4141 into 2770ed6a14353e3297285e45fd05...
Project fides
Branch Review refs/pull/5738/merge
Run status status check passed Passed #12201
Run duration 00m 49s
Commit git commit 6cc4e8531d ℹ️: Merge b95a563555f3f1210fd680d899beff5473cc4141 into 2770ed6a14353e3297285e45fd05...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera merged commit d759d6d into main Feb 6, 2025
20 checks passed
@lucanovera lucanovera deleted the LJ-343-Allow-searching-in-all-Select-components-by-default branch February 6, 2025 14:25
@cypress Cypress
Copy link

cypress bot commented Feb 6, 2025

fides    Run #12205

Run Properties:  status check passed Passed #12205  •  git commit d759d6d8fd: LJ-343 Allow search by default in all Selects (#5738)
Project fides
Branch Review main
Run status status check passed Passed #12205
Run duration 00m 50s
Commit git commit d759d6d8fd: LJ-343 Allow search by default in all Selects (#5738)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @gilluminate