Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract staticCall is in implemented as callStatic #924

Closed
zemse opened this issue Jul 2, 2020 · 2 comments
Closed

Contract staticCall is in implemented as callStatic #924

zemse opened this issue Jul 2, 2020 · 2 comments
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published.

Comments

@zemse
Copy link
Collaborator

zemse commented Jul 2, 2020

Hi @ricmoo, in the actual contract object I am seeing this as callStatic?

References: #395, documentation

defineReadOnly(this, "callStatic", { });
defineReadOnly(this, "estimateGas", { });
defineReadOnly(this, "functions", { });
defineReadOnly(this, "populateTransaction", { });

I think renaming the implemented callStatic to staticCall might cause people who already have implemented that (might be less though shouldn't be a problem what do you think?), or we can keep callStatic and updating the docs with the correct method.

Since I had blindly added the staticCall to the typechain ethers v5 target, now that I am actually using this part, I encountered this problem. If we are keeping callStatic then I will need to update it there.

@ricmoo
Copy link
Member

ricmoo commented Jul 2, 2020

Oh, I will fix the docs.

The API can no longer be changed as v5 is released and in the wild.

I’ll get to this today. :)

@ricmoo ricmoo added documentation Documentation related issue. on-deck This Enhancement or Bug is currently being worked on. labels Jul 3, 2020
zemse added a commit to zemse/TypeChain that referenced this issue Jul 3, 2020
zemse added a commit to zemse/TypeChain that referenced this issue Jul 3, 2020
@ricmoo
Copy link
Member

ricmoo commented Jul 5, 2020

I've updated the docs and published them.

Thanks! :)

@ricmoo ricmoo closed this as completed Jul 5, 2020
@ricmoo ricmoo added fixed/complete This Bug is fixed or Enhancement is complete and published. and removed on-deck This Enhancement or Bug is currently being worked on. labels Jul 19, 2020
softdevpro7 added a commit to softdevpro7/TypeChain that referenced this issue Nov 24, 2022
SuperStar0106 added a commit to SuperStar0106/Ganache that referenced this issue Jul 1, 2023
486xtm pushed a commit to 486xtm/chain-type that referenced this issue May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related issue. fixed/complete This Bug is fixed or Enhancement is complete and published.
Projects
None yet
Development

No branches or pull requests

2 participants