Fork/ethers v5 target #252
Conversation
Fix callStatic overrides for non constant fns
| const abstractFactoryFiles = Object.keys(this.contractCache).map((contractName) => { | ||
| const { contract, abi } = this.contractCache[contractName] | ||
| return { | ||
| path: join(this.outDirAbs, `${contract.name}Contract.ts`), |
There was a problem hiding this comment.
@krzkaczor this looks invalid, the file should still be named ...Factory.ts, since it still exports class ${contract.name}Factory.
@zemse was that a mistake or did you change this intentionally?
| path: join(this.outDirAbs, `${contract.name}Contract.ts`), | |
| path: join(this.outDirAbs, `${contract.name}Factory.ts`), |
(after the change we'll need to re-generate the files in packages/target-ethers-v5-test/types/ since they include the invalid filename)
There was a problem hiding this comment.
You're correct, there's a mistake here, this should be ${contract.name}Factory.ts. I'll create a PR to fix this.
This commit fixes a bug described in: #258 (comment)
|
BTW: I'm running the released |
|
I just published: @quezak yes, I think it's reasonable to publish it as stable this weekend 👍 |
|
Finally, published as: Thanks for everyone involved in this! Especially @zemse and @bradennapier! |
Published as
@typechain/ethers-v5