Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM release v4.2.0 #739

Merged
merged 24 commits into from
May 6, 2020
Merged

VM release v4.2.0 #739

merged 24 commits into from
May 6, 2020

Conversation

evertonfraga
Copy link
Contributor

I have added the commits until right before the monorepo transition, and cherry-picked the bugfix from #733. Given that we had some additions on #663 and #651, I am bumping a minor, instead of a patch. Full details are on the Changelog file.

I have created a branch called vm/release-v4.1.3 to support in the review process for this PR. It is identical to the v4.1.3 tag, so the branch can be deleted after releasing v4.2.0.

Note: this PR should not be merged. Branch vm/release-v4.2.0 should be kept.

s1na and others added 24 commits January 15, 2020 13:30
Runs tests with ts-node instead of node.
Fix Node v12 repo installation issue
* explicitly duplicate bignumbers on stack

* vm: add test to check for internally editing stack items

Co-authored-by: Ev <ev@ethereum.org>
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #739 into vm/release-v4.1.3 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           vm/release-v4.1.3     #739   +/-   ##
==================================================
  Coverage              91.40%   91.40%           
==================================================
  Files                     31       31           
  Lines                   1978     1978           
  Branches                 326      326           
==================================================
  Hits                    1808     1808           
  Misses                    90       90           
  Partials                  80       80           
Flag Coverage Δ
#vm 91.40% <100.00%> (ø)
Impacted Files Coverage Δ
lib/evm/eei.ts 94.53% <ø> (ø)
lib/evm/evm.ts 91.85% <ø> (ø)
lib/evm/interpreter.ts 98.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feef85f...40ae3cf. Read the comment docs.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, think this can be released.

@evertonfraga If you do the release can you also do a short announcement on https://gitter.im/ethereum/ethereumjs ? Thanks!

@holgerd77
Copy link
Member

Note: we should talk this through in our next call, eventually it might be better to rather keep a more generalized vm:4.x branch or something so that won't get clustered over time. Should also think about some consistent naming convention along.

@evertonfraga evertonfraga changed the base branch from vm/release-v4.1.3 to vm/4.x May 6, 2020 15:54
@evertonfraga evertonfraga merged commit c389bbb into vm/4.x May 6, 2020
@evertonfraga
Copy link
Contributor Author

@holgerd77, good idea. I created the branch vm/4.x and changed the base branch to it, so it can be safely merged now.

@evertonfraga evertonfraga deleted the vm/release-v4.2.0 branch May 6, 2020 16:36
@evertonfraga evertonfraga added this to the VM v5 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants