-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runs tests with ts-node instead of node. #654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
======================================
Coverage 91.4% 91.4%
======================================
Files 31 31
Lines 1978 1978
Branches 326 326
======================================
Hits 1808 1808
Misses 90 90
Partials 80 80
Continue to review full report at Codecov.
|
@evertonfraga Yes, running on |
Great! I will proceed with these changes. Thanks. |
@evertonfraga Ah, this is likely up again for review? Procedural note: better to just place another comment on stuff like this since GitHub is just not notifying on removing labels or stuff, then this is likely to be overlooked. Have updated the branch and will do a review and eventually merge once tests are through again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, this PR makes also some smaller code corrections along the way. Mainly had a look through the package.json
updates.
It also fixes a path bug when not using the --dist
option in the blockchain test runner.
Right, thanks! There'll be a second step to this category of changes, which will completely remove Example: https://github.com/ethereumjs/ethereumjs-vm/search?q=require+dist&unscoped_q=require+dist |
This PR aims to both kill some technical debt from the TypeScript migration and normalize how tests are run, in preparation for the monorepo migration. This way we won't need to move dist files across CI builds.
The sentence below can still be found in our documentation, although after the TypeScript migration that wasn't possible anymore:
Tests run against source by default. They can be run with the --dist flag
@holgerd77 The API test runners are all hardcoded to require from
dist/
. With your OK, I can make it work just likeblockchain
andstate
tests: testing against the source by default and againstdist/
using--dist
.