Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPT: New Release v4.1.0 #1108

Merged
merged 3 commits into from
Feb 16, 2021
Merged

MPT: New Release v4.1.0 #1108

merged 3 commits into from
Feb 16, 2021

Conversation

holgerd77
Copy link
Member

MPT release with the new checkpointing mechanism and other CI and docs related changes (see CHANGELOG).

Please notice that I reverted a Trie.setRoot() -> Trie._setRoot() rename (introduced by myself) from ethereumjs/merkle-patricia-tree#125 and switched to deprecating instead. This seemed to dangerous to me on retrospective regarding introducing a breaking change. Have instead added to #1024.

@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

Merging #1108 (d4916c9) into master (5fb23ad) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 81.69% <ø> (ø)
blockchain 84.19% <ø> (ø)
client 86.64% <ø> (ø)
common 86.97% <ø> (+0.63%) ⬆️
devp2p 84.27% <ø> (+0.31%) ⬆️
ethash 82.08% <ø> (ø)
tx 91.93% <ø> (ø)
vm 82.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

cgewecke
cgewecke previously approved these changes Feb 15, 2021
Copy link
Contributor

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

ryanio
ryanio previously approved these changes Feb 15, 2021
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@holgerd77 holgerd77 dismissed stale reviews from ryanio and cgewecke via 830c9d0 February 16, 2021 08:10
@holgerd77
Copy link
Member Author

Already reviewed and just updated the branch on tiny changes, will admin-merge for practical reasons.

@holgerd77 holgerd77 merged commit 9dfc747 into master Feb 16, 2021
@holgerd77 holgerd77 deleted the new-mpt-release branch February 16, 2021 08:57
@holgerd77
Copy link
Member Author

Just released this as v4.1.0 on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants