Fix homestead [WIP] #125
Merged
Fix homestead [WIP] #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jun 8, 2017
| try { | ||
| subGas(runState, new BN(fees.callNewAccountGas.v)) | ||
| } catch (e) { | ||
| done(e.error) |
There was a problem hiding this comment.
Shouldn't this be within a if (homestead) check?
There was a problem hiding this comment.
I think the rule that a 0-value call creates a new account (and pays the new account gas fee) was there in frontier.
There was a problem hiding this comment.
Right, the commit log was a bit misleading. It fixes a bug when there wasn't sufficient gas left.
axic
reviewed
Jun 8, 2017
| @@ -12,7 +12,7 @@ const codes = { | |||
| 0x08: ['ADDMOD', 8, 3, 1, false], | |||
| 0x09: ['MULMOD', 8, 3, 1, false], | |||
| 0x0a: ['EXP', 10, 2, 1, false], | |||
| 0x0b: ['SIGNEXTEND', 5, 1, 1, false], | |||
| 0x0b: ['SIGNEXTEND', 5, 2, 1, false], | |||
There was a problem hiding this comment.
Can you review the rest of the opcodes? Others might have bugs :)
axic
reviewed
Jun 8, 2017
lib/runCode.js
Outdated
| @@ -131,6 +128,10 @@ module.exports = function (opts, cb) { | |||
| return done(ERROR.STACK_UNDERFLOW) | |||
| } | |||
|
|
|||
| if (runState.stack.length - opInfo.in + opInfo.out > 1024) { | |||
There was a problem hiding this comment.
Can you enclose the left side in parentheses?
|
Note that #84 will also be needed to complete homestead. |
|
There is another bug, |
holgerd77
added a commit
that referenced
this pull request
Dec 1, 2020
Added eth_getBlockTransactionCountByHash RPC method
holgerd77
added a commit
that referenced
this pull request
Dec 14, 2020
…refactoring Base trie code documentation and function clustering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit prevents
runState.gasLimitfrom going negative and failing the test case call_OOG_additionalGasCosts1 under Homestead.The second commit fixes the shallowStack_d10g0v0_Homestead test case, which executes the bytecode
0x60010b600055:and should throw an OOG due to a stack underflow.
The third commit fixes some failing edge cases in the stackOverflow tests.