prefix hex values with 0x in RLP tests #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
approved these changes
Nov 29, 2018
|
Just some note: this definitely has to be stated in release notes, since this likely requires some changes on libraries using the tests and comparing results. |
AlexKnauth
added a commit
to AlexKnauth/tests
that referenced
this pull request
Feb 14, 2019
This finishes what ethereum#557 started, to use 0x prefixes consistently in rlptest.json, invalidRLPTest.json, and RandomRLPTests/example.json. This also updates the documentation in rlp_tests.rst describe the `0x` and `#` prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to prefix hex values with
0xso hex values can be in the input field. See #554