-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new test case not covered by RLP tests #554
Conversation
We discovered that our implementation of RLP encoding decodes some RLP binaries incorrectly after recent PR (mana-ethereum/ex_rlp#17) but it passes all RLP test cases. This PR adds a new test case which is not covered by existing RLP tests
Also, I suggest adding |
Adding hex prefixes here probably makes very much sense. Nevertheless don't introduce this here on only one new test case, since this makes test format syntax inconsistent. Instead let's address this separately on a new PR. |
I tested this new case over on our RLP implementation ethereumjs/rlp#47 and it currently fails, so I can't really help in confirming if the test case is valid (this might very well also be a bug in our implementation). 😄 |
@holgerd77 Can you please share what is the result of decoding in your implementation? |
@ayrat555 I had another look and came to the conclusion that we generally have a problem with our RLP library and should this test a lot better, we especially have some super-grave 0-value bug issue open which (probably) also came into effect here. So I will share our result, you will nevertheless probably not be able to do very much with it, this likely contains other bugs: f90316b88232393963613661636664333565336437326438626133643165326236306235353631643561663532313865623562633138323034353736396562343232363931306133303161636165336233363966666663346134383939643662303235333165383966643466653336613263663064393336303762613437306235306637383030b8806664613163666636373463393063396131393735333966653364666235333038366163653634663833656437633665616265633734316637663338316363383033653532616232636435356435353639626365343334373130376133313064666435663838613031306364326666643130303563613430366631383432383737b84037653936386262613133623663353065326334636437663234316363306436346431616332356337663539353264663233316163366132626461386565356436823034823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030823030 When having a second and somewhat more distant look on the current RLP tests file I came to the meta-conclusion that there should be actually much much more and also more structured test cases and this very much needs an overhaul and expansion in general. So much more systematically providing several tests for the different data types on a first round and then combinations of those in a second. |
@winsvega We were in the middle of a discussion if this is correct or can be confirmed or not. Have you checked in some way that this is the correct encoding result before merging this? |
oh. I thought it is finalised. Sorry.
|
could you please make another PR? |
We discovered that our implementation of RLP encoding decodes some RLP binaries incorrectly after recent PR (mana-ethereum/ex_rlp#17) but it passes all RLP test cases.
This PR adds a new test case which is not covered by existing RLP tests