-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Feature Branch ] Genesis allocs validation #489
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
commented
Aug 19, 2024
geoknee
commented
Aug 19, 2024
geoknee
commented
Aug 19, 2024
geoknee
commented
Aug 19, 2024
9 tasks
e5298f8
to
6e8b962
Compare
bitwiseguy
reviewed
Aug 20, 2024
bitwiseguy
reviewed
Aug 20, 2024
bitwiseguy
reviewed
Aug 20, 2024
bitwiseguy
reviewed
Aug 20, 2024
ec20e4a
to
11982b8
Compare
geoknee
commented
Aug 22, 2024
geoknee
commented
Aug 22, 2024
This was referenced Aug 23, 2024
Action plan:
|
This was referenced Aug 30, 2024
geoknee
commented
Aug 30, 2024
geoknee
commented
Aug 30, 2024
geoknee
commented
Aug 30, 2024
bitwiseguy
reviewed
Aug 30, 2024
bitwiseguy
reviewed
Aug 30, 2024
bitwiseguy
reviewed
Aug 30, 2024
* use dynamic config building in CI This works by having a small workflow run, compute the list of chain ids to run genesis validation checks on, and then modify a subsequent config file which circleci then runs. * add comment * fan in * fix * fix script * Update .circleci/continue_config.yml Co-authored-by: Vinod Damle <vdamle@users.noreply.github.com> --------- Co-authored-by: Vinod Damle <vdamle@users.noreply.github.com>
* git restore --source=main -- superchain * just codegen * just lint-all * lint * typo
to retain chronological ordering
9a6e826
to
9b7f6d8
Compare
1 task
bitwiseguy
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add-chain
flow to store sufficient metadata to validate the allocs in a chain's genesis filegenesis
package under thevalidation
module, which contains a test to perform full genesis allocs validationCloses #486
Closes #372
Towards #478